From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Douglas Anderson <dianders@chromium.org>,
"ath11k@lists.infradead.org" <ath11k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>,
"junyuu@chromium.org" <junyuu@chromium.org>,
Youghandhar Chintala <quic_youghand@quicinc.com>,
Jiri Slaby <jirislaby@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Marc Zyngier <maz@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] wifi: ath5k: Use platform_get_irq() to get the interrupt
Date: Wed, 1 Feb 2023 20:44:35 +0000 [thread overview]
Message-ID: <OSZPR01MB7019B1D2D0367354BF03F5D3AAD19@OSZPR01MB7019.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230201084131.v2.2.Ic4f8542b0588d7eb4bc6e322d4af3d2064e84ff0@changeid>
Hi Douglas,
Thank you for the patch.
> Subject: [PATCH v2 2/2] wifi: ath5k: Use platform_get_irq() to get the interrupt
>
> As of commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core"), we need to
> use platform_get_irq() instead of
> platform_get_resource() to get our IRQs because
> platform_get_resource() simply won't get them anymore.
>
> This was already fixed in several other Atheros WiFi drivers, apparently in response to Zeal Robot
> reports. An example of another fix is commit 9503a1fc123d ("ath9k: Use platform_get_irq() to get the
> interrupt"). ath5k seems to have been missed in this effort, though.
>
> Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> I'm not setup to actually test this, but I figured that I might as well go all the way and fix all the
> instances of the same pattern that I found in the ath drivers since the old call was actually breaking
> me in ath11k. I did at least confirm that the code compiles for me.
>
> If folks would rather not land an untested patch like this, though, feel free to drop this and just
> land patch #1 as long as that one looks OK.
>
> Changes in v2:
> - Update commit message and point to patch that broke us (Jonas)
>
> drivers/net/wireless/ath/ath5k/ahb.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 2c9cec8b53d9..28a1e5eff204 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -113,15 +113,13 @@ static int ath_ahb_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (res == NULL) {
> - dev_err(&pdev->dev, "no IRQ resource found\n");
> - ret = -ENXIO;
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
> + ret = irq;
> goto err_iounmap;
> }
>
> - irq = res->start;
> -
> hw = ieee80211_alloc_hw(sizeof(struct ath5k_hw), &ath5k_hw_ops);
> if (hw == NULL) {
> dev_err(&pdev->dev, "no memory for ieee80211_hw\n");
> --
> 2.39.1.456.gfc5497dd1b-goog
next prev parent reply other threads:[~2023-02-01 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 16:54 [PATCH v2 1/2] wifi: ath11k: Use platform_get_irq() to get the interrupt Douglas Anderson
2023-02-01 16:54 ` [PATCH v2 2/2] wifi: ath5k: " Douglas Anderson
2023-02-01 20:44 ` Prabhakar Mahadev Lad [this message]
2023-02-01 20:39 ` [PATCH v2 1/2] wifi: ath11k: " Prabhakar Mahadev Lad
2023-02-22 9:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSZPR01MB7019B1D2D0367354BF03F5D3AAD19@OSZPR01MB7019.jpnprd01.prod.outlook.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=edumazet@google.com \
--cc=jirislaby@kernel.org \
--cc=junyuu@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_youghand@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).