From: Simon Horman <simon.horman@corigine.com>
To: Bo Liu <liubo03@inspur.com>
Cc: johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] rfkill: Use sysfs_emit() to instead of sprintf()
Date: Mon, 6 Feb 2023 11:04:52 +0100 [thread overview]
Message-ID: <Y+DQxN9ybYqfozRr@corigine.com> (raw)
In-Reply-To: <20230206081641.3193-1-liubo03@inspur.com>
On Mon, Feb 06, 2023 at 03:16:41AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
> net/rfkill/core.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Hi Bo Liu,
A brief summary of changes since v1 should go here.
Comparing v1 and v2 manually, I see that you have addressed the minor
issues raised in the review of v1:
* the checkpatch warning regarding ' )'
* Including target tree, net-next, in subject
Ref: https://lore.kernel.org/netdev/Y91bc2LWMl+DsjcW@corigine.com/
So, FWIIW, I am happy with this patch now.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
prev parent reply other threads:[~2023-02-06 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 8:16 [PATCH net-next v2] rfkill: Use sysfs_emit() to instead of sprintf() Bo Liu
2023-02-06 10:04 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+DQxN9ybYqfozRr@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).