From: Luis Chamberlain <mcgrof@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Nick Kossifidis <mickflemm@gmail.com>,
Youghandhar Chintala <quic_youghand@quicinc.com>,
junyuu@chromium.org, Kalle Valo <kvalo@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: ath11k: Use platform_get_irq() to get the interrupt
Date: Thu, 26 Jan 2023 11:01:35 -0800 [thread overview]
Message-ID: <Y9LODwJPQpPs32Ds@bombadil.infradead.org> (raw)
In-Reply-To: <20230124110057.1.I69cf3d56c97098287fe3a70084ee515098390b70@changeid>
On Tue, Jan 24, 2023 at 11:01:00AM -0800, Douglas Anderson wrote:
> For the same reasons talked about in commit 9503a1fc123d ("ath9k: Use
> platform_get_irq() to get the interrupt"), we should be using
> platform_get_irq() in ath11k. Let's make the switch.
The commit log is rather weak, it is better to re-state what the commit
log in 9503a1fc123d states as it is stronger, and very clear.
To that end. Why not write an SmPL Coccinelle grammer patch for this
and put it on scripts/coccinelle/api ? Then hunt / convert things which
will use DT as well and where this is actually useful / likely buggy.
Luis
next prev parent reply other threads:[~2023-01-26 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 19:01 [PATCH 1/2] wifi: ath11k: Use platform_get_irq() to get the interrupt Douglas Anderson
2023-01-24 19:01 ` [PATCH 2/2] wifi: ath5k: " Douglas Anderson
2023-01-26 10:16 ` [PATCH 1/2] wifi: ath11k: " Jonas Gorski
2023-01-26 19:01 ` Luis Chamberlain [this message]
2023-01-27 0:14 ` Doug Anderson
2023-01-27 0:27 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9LODwJPQpPs32Ds@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=edumazet@google.com \
--cc=jirislaby@kernel.org \
--cc=junyuu@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_mpubbise@quicinc.com \
--cc=quic_youghand@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).