From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8C9C432BE for ; Wed, 28 Jul 2021 05:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 709F4600EF for ; Wed, 28 Jul 2021 05:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234401AbhG1Fqh (ORCPT ); Wed, 28 Jul 2021 01:46:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:48910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233485AbhG1Fqc (ORCPT ); Wed, 28 Jul 2021 01:46:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB34560F00; Wed, 28 Jul 2021 05:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627451190; bh=RkniVPw58x8HtXFNZtC6iw7u6agFRS3hIJcKdd+55ec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DSebIApW9TVBAUK7OJ/Tb8IqORU/SGsPM3aWGnOEmtfhuKuwrzn0QtsCBUDuV6gqM yOHBji91agAgQERWWduJrLj9K/W8yyM7nH4QV70xYPcZBkujd6YERI4gwzXwo+otKh wLtgvqZimQZTA1U1liKqT622nMyjaIAZgegBMcNI= Date: Wed, 28 Jul 2021 07:46:27 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: linux-hardening@vger.kernel.org, "Gustavo A. R. Silva" , Keith Packard , Andrew Morton , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 09/64] staging: rtl8723bs: Avoid field-overflowing memcpy() Message-ID: References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-10-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727205855.411487-10-keescook@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jul 27, 2021 at 01:58:00PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Adjust memcpy() destination to be the named structure itself, rather than > the first member, allowing memcpy() to correctly reason about the size. > > "objdump -d" shows no object code changes. > > Signed-off-by: Kees Cook > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Greg Kroah-Hartman