From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7CEC432BE for ; Thu, 19 Aug 2021 23:38:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DA22610FF for ; Thu, 19 Aug 2021 23:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236952AbhHSXjV (ORCPT ); Thu, 19 Aug 2021 19:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233964AbhHSXjU (ORCPT ); Thu, 19 Aug 2021 19:39:20 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17A70C061575 for ; Thu, 19 Aug 2021 16:38:44 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id u10so10769954oiw.4 for ; Thu, 19 Aug 2021 16:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Xct87dPQUKJVUu3N8FqHnD1YvrlqEBt4s0ORd5SdpdM=; b=eudFGYTfZ16z1QhF2vBkVkOEGuyji6cJHYfDN+vaWhHK9+rd5vH14VbxAFS+2eC/Oa 4Ba8R/88FJ/OPWCZCtBMsieEh/pm7qtYFwo0TirY0lTm7yCkB4ikLG4icFgNZa27zUvD BJBWXenoc7pm9fKQWpviuAKcgL8Df47rbgz6yQURrhmHOtRSecJ10uQ/D9jJoKjchcaT N88vkjjFz7L88TbHiR07A5xpRDrDWzx7jyyWYQNuz4UGLkZj+Y+eCNAqTYc3PrKVQ9mE uxtGqO5cni67yc6BYcRmxcxcBMWHGdqV0DZH4RZws/7uEVXHrYjTkJDfXhbO+YTxMWd0 nkfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Xct87dPQUKJVUu3N8FqHnD1YvrlqEBt4s0ORd5SdpdM=; b=Us47IS4p/W5Kle5TsYrs5ywAO5RQV5XVp4mNzAMz+Td/s6MmHB481kT1UpJpfoDPLY M8NtiFv8j7QpVz0QjqlrDHmBHHAg/mbZatW7DuTqigfrQHc7NbcsYhhRStmbC/jyZvcT 2qhAcK5q9/EN041p6JXLK33SipNnkYcx7gu/ObcoyGuHo/h8GakXKVZYVjdipk/1Fc2b 9X3YRHOX3DT/69o768+iAy1/7XlWvtavk2uIfP321864N5OINKW481ewBUcWmUzpbV70 fg7YHF/9UojgqAIfBZLbhlMRFPK+0bkuvk5phlpXJUo1DOJ3/1N9KCcnVg2j7XGb0bE0 edSg== X-Gm-Message-State: AOAM533azL8nADrlD0DHA//EockIqLCtOahLqya+uw4O0nUvgovHMGK8 wUSEFFUfVa2yOdl5eVhB9vTcMg== X-Google-Smtp-Source: ABdhPJwkOK+fwhCjDa07/ZAhRRmQGSXN+VsHKhGQP49+rc5kMdF59S4PHF0J6u327Ln2bdc4Y0LlgA== X-Received: by 2002:a05:6808:1494:: with SMTP id e20mr861952oiw.111.1629416323497; Thu, 19 Aug 2021 16:38:43 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j2sm999557oia.21.2021.08.19.16.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 16:38:43 -0700 (PDT) Date: Thu, 19 Aug 2021 16:40:06 -0700 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Ulf Hansson , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Kalle Valo , "David S. Miller" , Jakub Kicinski , Stanimir Varbanov , linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH 11/15] arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power sequencer Message-ID: References: <20210817005507.1507580-1-dmitry.baryshkov@linaro.org> <20210817005507.1507580-12-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817005507.1507580-12-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon 16 Aug 17:55 PDT 2021, Dmitry Baryshkov wrote: > Switch sdm845-db845c device tree to use new power sequencer driver > rather than separate regulators. > LGTM! > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 21 ++++++++++++++------- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ > 2 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 2d5533dd4ec2..c9b694e934d4 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -629,6 +629,16 @@ &qupv3_id_1 { > status = "okay"; > }; > > +&qca_pwrseq { > + status = "okay"; > + > + vddio-supply = <&vreg_s4a_1p8>; > + > + vddxo-supply = <&vreg_l7a_1p8>; > + vddrfa-supply = <&vreg_l17a_1p3>; > + vddch0-supply = <&vreg_l25a_3p3>; > +}; > + > &sdhc_2 { > status = "okay"; > > @@ -916,10 +926,8 @@ &uart6 { > bluetooth { > compatible = "qcom,wcn3990-bt"; > > - vddio-supply = <&vreg_s4a_1p8>; > - vddxo-supply = <&vreg_l7a_1p8>; > - vddrf-supply = <&vreg_l17a_1p3>; > - vddch0-supply = <&vreg_l25a_3p3>; > + bt-pwrseq = <&qca_pwrseq 1>; I suppose there will be a DT binding and some defines for the WiFi/BT argument to &qca_pwrseq? Regards, Bjorn > + > max-speed = <3200000>; > }; > }; > @@ -1036,9 +1044,8 @@ &wifi { > status = "okay"; > > vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>; > - vdd-1.8-xo-supply = <&vreg_l7a_1p8>; > - vdd-1.3-rfa-supply = <&vreg_l17a_1p3>; > - vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; > + > + wifi-pwrseq = <&qca_pwrseq 0>; > > qcom,snoc-host-cap-8bit-quirk; > }; > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 0a86fe71a66d..78e889b2c8dd 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -1051,6 +1051,12 @@ psci { > method = "smc"; > }; > > + qca_pwrseq: qca-pwrseq { > + compatible = "qcom,wcn3990-pwrseq"; > + #pwrseq-cells = <1>; > + status = "disabled"; > + }; > + > soc: soc@0 { > #address-cells = <2>; > #size-cells = <2>; > -- > 2.30.2 >