From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84847C433EF for ; Tue, 5 Oct 2021 08:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67DA661354 for ; Tue, 5 Oct 2021 08:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233286AbhJEIXX (ORCPT ); Tue, 5 Oct 2021 04:23:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233215AbhJEIXT (ORCPT ); Tue, 5 Oct 2021 04:23:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CD36061352; Tue, 5 Oct 2021 08:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633422089; bh=U6uwtdCtTV5GlnkRiRrDaVENdO7F58zTTa2A8saHYBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SAZFp7+jmCcTt6F6GBOXHjV7ZR+QQ29xj949iJyGjpEx3IvUT84zr2peZxssWnfn7 zmOivEkMocoZolUo6djRaD2zkqxuS71rA96nRUjXqd2UAPjVbJp+172s2axg2JL2gj Jkr9ADll/Nk9iyV9bwwfL2DV1KdIfC67ePX/iVxA= Date: Tue, 5 Oct 2021 10:21:27 +0200 From: Greg Kroah-Hartman To: =?iso-8859-1?B?Suly9G1l?= Pouiller Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Kalle Valo , devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Ulf Hansson , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-mmc@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH v7 13/24] wfx: add hif_tx*.c/hif_tx*.h Message-ID: References: <20210920161136.2398632-1-Jerome.Pouiller@silabs.com> <20211001161316.w3cwsigacznjbowl@pali> <87tuhwf19w.fsf@codeaurora.org> <36155992.WRNEVsFkd7@pc-42> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36155992.WRNEVsFkd7@pc-42> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Oct 05, 2021 at 10:17:32AM +0200, Jérôme Pouiller wrote: > On Tuesday 5 October 2021 08:12:27 CEST Kalle Valo wrote: > > Pali Rohár writes: > > > On Friday 01 October 2021 17:17:52 Jérôme Pouiller wrote: > > >> On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote: > > >> > Jerome Pouiller writes: > > >> > > > >> > > From: Jérôme Pouiller > > >> > > > > >> > > Signed-off-by: Jérôme Pouiller > > >> > > > >> > [...] > > >> > > > >> > > --- /dev/null > > >> > > +++ b/drivers/net/wireless/silabs/wfx/hif_tx_mib.h > > >> > > @@ -0,0 +1,49 @@ > > >> > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > >> > > +/* > > >> > > + * Implementation of the host-to-chip MIBs of the hardware API. > > >> > > + * > > >> > > + * Copyright (c) 2017-2020, Silicon Laboratories, Inc. > > >> > > + * Copyright (c) 2010, ST-Ericsson > > >> > > + * Copyright (C) 2010, ST-Ericsson SA > > >> > > + */ > > >> > > +#ifndef WFX_HIF_TX_MIB_H > > >> > > +#define WFX_HIF_TX_MIB_H > > >> > > + > > >> > > +struct wfx_vif; > > >> > > +struct sk_buff; > > >> > > + > > >> > > +int hif_set_output_power(struct wfx_vif *wvif, int val); > > >> > > +int hif_set_beacon_wakeup_period(struct wfx_vif *wvif, > > >> > > + unsigned int dtim_interval, > > >> > > + unsigned int listen_interval); > > >> > > +int hif_set_rcpi_rssi_threshold(struct wfx_vif *wvif, > > >> > > + int rssi_thold, int rssi_hyst); > > >> > > +int hif_get_counters_table(struct wfx_dev *wdev, int vif_id, > > >> > > + struct hif_mib_extended_count_table *arg); > > >> > > +int hif_set_macaddr(struct wfx_vif *wvif, u8 *mac); > > >> > > +int hif_set_rx_filter(struct wfx_vif *wvif, > > >> > > + bool filter_bssid, bool fwd_probe_req); > > >> > > +int hif_set_beacon_filter_table(struct wfx_vif *wvif, int tbl_len, > > >> > > + const struct hif_ie_table_entry *tbl); > > >> > > +int hif_beacon_filter_control(struct wfx_vif *wvif, > > >> > > + int enable, int beacon_count); > > >> > > +int hif_set_operational_mode(struct wfx_dev *wdev, enum > > >> > > hif_op_power_mode mode); > > >> > > +int hif_set_template_frame(struct wfx_vif *wvif, struct sk_buff *skb, > > >> > > + u8 frame_type, int init_rate); > > >> > > +int hif_set_mfp(struct wfx_vif *wvif, bool capable, bool required); > > >> > > +int hif_set_block_ack_policy(struct wfx_vif *wvif, > > >> > > + u8 tx_tid_policy, u8 rx_tid_policy); > > >> > > +int hif_set_association_mode(struct wfx_vif *wvif, int ampdu_density, > > >> > > + bool greenfield, bool short_preamble); > > >> > > +int hif_set_tx_rate_retry_policy(struct wfx_vif *wvif, > > >> > > + int policy_index, u8 *rates); > > >> > > +int hif_keep_alive_period(struct wfx_vif *wvif, int period); > > >> > > +int hif_set_arp_ipv4_filter(struct wfx_vif *wvif, int idx, __be32 *addr); > > >> > > +int hif_use_multi_tx_conf(struct wfx_dev *wdev, bool enable); > > >> > > +int hif_set_uapsd_info(struct wfx_vif *wvif, unsigned long val); > > >> > > +int hif_erp_use_protection(struct wfx_vif *wvif, bool enable); > > >> > > +int hif_slot_time(struct wfx_vif *wvif, int val); > > >> > > +int hif_wep_default_key_id(struct wfx_vif *wvif, int val); > > >> > > +int hif_rts_threshold(struct wfx_vif *wvif, int val); > > >> > > > >> > "wfx_" prefix missing from quite a few functions. > > >> > > >> I didn't know it was mandatory to prefix all the functions with the > > >> same prefix. > > > > I don't know either if this is mandatory or not, for example I do not > > have any recollection what Linus and other maintainers think of this. I > > just personally think it's good practise to use driver prefix ("wfx_") > > in all non-static functions. > > What about structs (especially all the structs from hif_api.*.h)? Do you > think I should also prefix them with wfx_? Why would they _not_ have wfx_ as a prefix if they only pertain to this driver? thanks, greg k-h