From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jonas Dreßler" <verdre@v0yd.nl>
Cc: "Amitkumar Karwar" <amitkarwar@gmail.com>,
"Ganapathi Bhat" <ganapathi017@gmail.com>,
"Xinming Hu" <huxinming820@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Tsuchiya Yuto" <kitakar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2 1/2] mwifiex: Use a define for firmware version string length
Date: Wed, 3 Nov 2021 16:17:33 +0200 [thread overview]
Message-ID: <YYKZ/a11TEs48+Xb@smile.fi.intel.com> (raw)
In-Reply-To: <20211103135529.8537-2-verdre@v0yd.nl>
On Wed, Nov 03, 2021 at 02:55:28PM +0100, Jonas Dreßler wrote:
> Since the version string we get from the firmware is always 128
> characters long, use a define for this size instead of having the number
> 128 copied all over the place.
Just answered to the previous one :-) Okay, you may ignore that thread
since you did what you and I were talking about.
...
> + sizeof(char) * MWIFIEX_VERSION_STR_LENGTH);
While at it, drop the redundant sizeof().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-03 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 13:55 [PATCH v2 0/2] mwifiex: Add quirk to disable deep sleep with certain hardware revision Jonas Dreßler
2021-11-03 13:55 ` [PATCH v2 1/2] mwifiex: Use a define for firmware version string length Jonas Dreßler
2021-11-03 14:17 ` Andy Shevchenko [this message]
2021-11-03 13:55 ` [PATCH v2 2/2] mwifiex: Add quirk to disable deep sleep with certain hardware revision Jonas Dreßler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYKZ/a11TEs48+Xb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amitkarwar@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).