From: Greg KH <gregkh@linuxfoundation.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Hans Ulli Kroll <linux@ulli-kroll.de>,
Larry Finger <Larry.Finger@lwfinger.net>,
Pkshih <pkshih@realtek.com>, Tim K <tpkuester@gmail.com>,
"Alex G ." <mr.nuke.me@gmail.com>,
Nick Morrow <morrownr@gmail.com>,
Viktor Petrenko <g0000ga@gmail.com>,
Andreas Henriksson <andreas@fatal.se>,
ValdikSS <iam@valdikss.org.ru>,
kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: rtw88: rtw8821c: Fix rfe_option field width
Date: Fri, 31 Mar 2023 15:16:47 +0200 [thread overview]
Message-ID: <ZCbdP11nqQinOQNe@kroah.com> (raw)
In-Reply-To: <20230331121054.112758-3-s.hauer@pengutronix.de>
On Fri, Mar 31, 2023 at 02:10:54PM +0200, Sascha Hauer wrote:
> On my RTW8821CU chipset rfe_option reads as 0x22. Looking at the
> downstream driver suggests that the field width of rfe_option is 5 bit,
> so rfe_option should be masked with 0x1f.
>
> Without this the rfe_option comparisons with 2 further down the
> driver evaluate as false when they should really evaluate as true.
> The effect is that 2G channels do not work.
>
> rfe_option is also used as an array index into rtw8821c_rfe_defs[].
> rtw8821c_rfe_defs[34] (0x22) was added as part of adding USB support,
> likely because rfe_option reads as 0x22. As this now becomes 0x2,
> rtw8821c_rfe_defs[34] is no longer used and can be removed.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8821c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2023-03-31 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 12:10 [PATCH 0/2] RTW88 USB bug fixes Sascha Hauer
2023-03-31 12:10 ` [PATCH 1/2] wifi: rtw88: usb: fix priority queue to endpoint mapping Sascha Hauer
2023-03-31 14:31 ` Jonathan Bither
2023-04-04 7:11 ` Sascha Hauer
2023-03-31 12:10 ` [PATCH 2/2] wifi: rtw88: rtw8821c: Fix rfe_option field width Sascha Hauer
2023-03-31 13:16 ` Greg KH [this message]
2023-03-31 20:34 ` [PATCH 0/2] RTW88 USB bug fixes Alex G.
2023-04-01 2:05 ` Larry Finger
2023-04-01 2:08 ` ValdikSS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCbdP11nqQinOQNe@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=andreas@fatal.se \
--cc=g0000ga@gmail.com \
--cc=iam@valdikss.org.ru \
--cc=kernel@pengutronix.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@ulli-kroll.de \
--cc=morrownr@gmail.com \
--cc=mr.nuke.me@gmail.com \
--cc=pkshih@realtek.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=tpkuester@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).