From: Kevin Lo <kevlo@kevlo.org>
To: linux-wireless@vger.kernel.org
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Jes Sorensen <Jes.Sorensen@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>
Subject: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts
Date: Fri, 28 Apr 2023 10:34:17 +0800 [thread overview]
Message-ID: <ZEswqUHBXPHC/znL@ns.kevlo.org> (raw)
There's no need to initialize interrupts for RTL8188FTV like the vendor driver.
Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
v2:
- Fix my email address.
---
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 620a5cc2bfdd..7f620dc47ee0 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4023,9 +4023,6 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
if (priv->rtl_chip == RTL8192E) {
rtl8xxxu_write32(priv, REG_HIMR0, 0x00);
rtl8xxxu_write32(priv, REG_HIMR1, 0x00);
- } else if (priv->rtl_chip == RTL8188F) {
- rtl8xxxu_write32(priv, REG_HISR0, 0xffffffff);
- rtl8xxxu_write32(priv, REG_HISR1, 0xffffffff);
} else if (priv->rtl_chip == RTL8188E) {
rtl8xxxu_write32(priv, REG_HISR0, 0xffffffff);
val32 = IMR0_PSTIMEOUT | IMR0_TBDER | IMR0_CPWM | IMR0_CPWM2;
@@ -4035,7 +4032,7 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw)
val8 = rtl8xxxu_read8(priv, REG_USB_SPECIAL_OPTION);
val8 |= USB_SPEC_INT_BULK_SELECT;
rtl8xxxu_write8(priv, REG_USB_SPECIAL_OPTION, val8);
- } else {
+ } else if (priv->rtl_chip != RTL8188F) {
/*
* Enable all interrupts - not obvious USB needs to do this
*/
next reply other threads:[~2023-04-28 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 2:34 Kevin Lo [this message]
2023-04-28 5:40 ` [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts Kalle Valo
2023-04-28 6:34 ` Kevin Lo
2023-05-02 9:10 ` Ping-Ke Shih
2023-05-05 5:27 ` Kevin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEswqUHBXPHC/znL@ns.kevlo.org \
--to=kevlo@kevlo.org \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).