From: You-Sheng Yang <vicamo@gmail.com>
To: Luca Coelho <luca@coelho.fi>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5.7] iwlwifi: pcie: handle QuZ configs with killer NICs as well
Date: Mon, 27 Apr 2020 19:51:26 +0800 [thread overview]
Message-ID: <a0c8da44-1daa-07ba-3837-34f4d1aefb28@gmail.com> (raw)
In-Reply-To: <f056d364-d85d-8acd-dd74-7d1b64f6d6ae@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1833 bytes --]
[update]
With that cfg/iwl_trans->cfg usage corrected, this patch brings Killer
series back to live. Thank you.
Tested-by: You-Sheng Yang <vicamo@gmail.com>
On 2020-04-27 14:50, You-Sheng Yang wrote:
> Hi Luca,
>
> I have backported this to Ubuntu kernels in my ppa[1], and it doesn't
> really fix firmware crash on Killer(R) Wi-Fi 6 AX1650i 160MHz Wireless
> Network Adapter (201NGW), REV=0x354 [8086:a0f0] subsystem id [1a56:1651].
>
> [1]: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1874685
>
> You-Sheng Yang
>
> On 2020-04-24 17:20, Luca Coelho wrote:
>> From: Luca Coelho <luciano.coelho@intel.com>
>>
>> The killer devices were left out of the checks that convert Qu-B0 to
>> QuZ configurations. Add them.
>>
>> Cc: stable@vger.kernel.org # v5.3+
>> Fixes: 5a8c31aa6357 ("iwlwifi: pcie: fix recognition of QuZ devices")
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> ---
>> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> index 6744c0281ffb..29971c25dba4 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> @@ -1092,6 +1092,10 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>> iwl_trans->cfg = &iwl_ax101_cfg_quz_hr;
>> else if (iwl_trans->cfg == &iwl_ax201_cfg_qu_hr)
>> iwl_trans->cfg = &iwl_ax201_cfg_quz_hr;
>> + else if (iwl_trans->cfg == &killer1650s_2ax_cfg_qu_b0_hr_b0)
>> + iwl_trans->cfg = &iwl_ax1650s_cfg_quz_hr;
>> + else if (iwl_trans->cfg == &killer1650i_2ax_cfg_qu_b0_hr_b0)
>> + iwl_trans->cfg = &iwl_ax1650i_cfg_quz_hr;
>> }
>>
>> #endif
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-27 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:20 [PATCH v5.7] iwlwifi: pcie: handle QuZ configs with killer NICs as well Luca Coelho
2020-04-26 15:03 ` Sasha Levin
2020-04-27 7:07 ` You-Sheng Yang
2020-04-27 6:50 ` You-Sheng Yang
2020-04-27 11:51 ` You-Sheng Yang [this message]
2020-04-27 12:16 ` Luca Coelho
2020-04-27 12:16 ` Luca Coelho
2020-05-08 10:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c8da44-1daa-07ba-3837-34f4d1aefb28@gmail.com \
--to=vicamo@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).