From: Ben Greear <greearb@candelatech.com>
To: Bo Jiao <bo.jiao@mediatek.com>, Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Xing Song <xing.song@mediatek.com>,
Sujuan Chen <sujuan.chen@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 02/11] mt76: mt7915: refine register definition
Date: Fri, 12 Nov 2021 12:05:13 -0800 [thread overview]
Message-ID: <a11f6064-6886-1cfc-38e3-6fe9bf6ea2d7@candelatech.com> (raw)
In-Reply-To: <3ba42e47ae9cc7630e1f9b82955871fb90349f94.1636105953.git.Bo.Jiao@mediatek.com>
On 11/5/21 3:02 AM, Bo Jiao wrote:
> From: Bo Jiao <Bo.Jiao@mediatek.com>
>
> Add mt7915_reg_desc to differentiate chip generations.
> This is an intermediate patch to introduce mt7916 support.
While merging this into my patched tree, I noticed this discrepency,
it seems this patch is changing the value for SDR32/33 and/or confusing
SDR32 with SDR33.
Is this on purpose?
[greearb@ben-dt4 linux-5.16.dev.y]$ git am --show-current-patch|grep 088
+ [MIB_SDR32] = { INVALID_BASE, 0x088 },
-#define MT_MIB_SDR32(_band) MT_WF_MIB(_band, 0x088)
+#define MT_MIB_SDR33(_band) MT_WF_MIB(_band, 0x088)
[greearb@ben-dt4 linux-5.16.dev.y]$ git am --show-current-patch|grep SDR32
cnt = mt76_rr(dev, MT_MIB_SDR32(ext_phy));
mib->tx_pkt_ebf_cnt += FIELD_GET(MT_MIB_SDR32_TX_PKT_EBF_CNT_MASK, cnt);
+ [MIB_SDR32] = { INVALID_BASE, 0x088 },
+ [MIB_SDR32] = { INVALID_BASE, 0x7a8 },
+ MIB_SDR32,
-#define MT_MIB_SDR32(_band) MT_WF_MIB(_band, 0x088)
+#define MT_MIB_SDR32(_band) MT_WF_MIB(_band, __REG_OFFS(dev, MIB_SDR32))
#define MT_MIB_SDR32_TX_PKT_EBF_CNT_MASK GENMASK(15, 0)
+#define MT_MIB_SDR32_TX_PKT_IBF_CNT_MASK __MASK(dev, MIB_BF_TX_CNT)
[greearb@ben-dt4 linux-5.16.dev.y]$ git am --show-current-patch|grep SDR33
- cnt = mt76_rr(dev, MT_MIB_SDR33(ext_phy));
- mib->tx_pkt_ibf_cnt += FIELD_GET(MT_MIB_SDR33_TX_PKT_IBF_CNT_MASK, cnt);
+ cnt = mt76_rr(dev, MT_MIB_SDR33(ext_phy));
-#define MT_MIB_SDR33(_band) MT_WF_MIB(_band, 0x08c)
-#define MT_MIB_SDR33_TX_PKT_IBF_CNT_MASK GENMASK(15, 0)
+#define MT_MIB_SDR33(_band) MT_WF_MIB(_band, 0x088)
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2021-11-12 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 10:01 [PATCH v2 00/11] add mt7916 support Bo Jiao
2021-11-05 10:02 ` [PATCH v2 01/11] mt76: mt7915: add mt7915_mmio_probe() as a common probing function Bo Jiao
2021-11-05 10:02 ` [PATCH v2 02/11] mt76: mt7915: refine register definition Bo Jiao
2021-11-12 20:05 ` Ben Greear [this message]
2021-11-05 10:02 ` [PATCH v2 03/11] mt76: mt7915: rework dma.c to adapt mt7916 changes Bo Jiao
2021-11-05 10:02 ` [PATCH v2 04/11] mt76: mt7915: add firmware support for mt7916 Bo Jiao
2021-11-12 22:30 ` Ben Greear
2021-11-05 10:02 ` [PATCH v2 05/11] mt76: mt7915: rework eeprom.c to adapt mt7916 changes Bo Jiao
2021-11-05 10:02 ` [PATCH v2 06/11] mt76: mt7915: enlarge wcid size to 544 Bo Jiao
2021-11-05 10:02 ` [PATCH v2 07/11] mt76: mt7915: add txfree event v3 Bo Jiao
2021-11-05 10:02 ` [PATCH v2 08/11] mt76: mt7915: update rx rate reporting for mt7916 Bo Jiao
2021-11-05 10:02 ` [PATCH v2 09/11] mt76: mt7915: update mt7915_chan_mib_offs " Bo Jiao
2021-11-05 10:02 ` [PATCH v2 10/11] mt76: mt7915: add mt7916 calibrated data support Bo Jiao
2021-11-05 10:02 ` [PATCH v2 11/11] mt76: mt7915: add device id for mt7916 Bo Jiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11f6064-6886-1cfc-38e3-6fe9bf6ea2d7@candelatech.com \
--to=greearb@candelatech.com \
--cc=bo.jiao@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
--cc=xing.song@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).