* [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info
@ 2018-10-05 9:02 YueHaibing
2018-10-17 7:25 ` Luciano Coelho
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2018-10-05 9:02 UTC (permalink / raw)
To: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, Kalle Valo
Cc: YueHaibing, linux-wireless, kernel-janitors
Use kmemdup rather than duplicating its implementation
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
index ec300d3..d979c00 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c
@@ -1108,14 +1108,12 @@ struct ieee80211_regdomain *
regd_to_copy = sizeof(struct ieee80211_regdomain) +
valid_rules * sizeof(struct ieee80211_reg_rule);
- copy_rd = kzalloc(regd_to_copy, GFP_KERNEL);
+ copy_rd = kmemdup(regd, regd_to_copy, GFP_KERNEL);
if (!copy_rd) {
copy_rd = ERR_PTR(-ENOMEM);
goto out;
}
- memcpy(copy_rd, regd, regd_to_copy);
-
out:
kfree(regdb_ptrs);
kfree(regd);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info
2018-10-05 9:02 [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info YueHaibing
@ 2018-10-17 7:25 ` Luciano Coelho
2018-10-17 7:48 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Luciano Coelho @ 2018-10-17 7:25 UTC (permalink / raw)
To: YueHaibing, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, Kalle Valo
Cc: linux-wireless, kernel-janitors
On Fri, 2018-10-05 at 09:02 +0000, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Thanks, YueHaibing. I have applied this in our internal tree and it
will eventually reach the mainline, following our normal upstreaming
process.
I have modified the subject and the commit message a bit.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info
2018-10-17 7:25 ` Luciano Coelho
@ 2018-10-17 7:48 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-10-17 7:48 UTC (permalink / raw)
To: Luciano Coelho, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless, Kalle Valo
Cc: linux-wireless, kernel-janitors
On 2018/10/17 15:25, Luciano Coelho wrote:
> On Fri, 2018-10-05 at 09:02 +0000, YueHaibing wrote:
>> Use kmemdup rather than duplicating its implementation
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>
> Thanks, YueHaibing. I have applied this in our internal tree and it
> will eventually reach the mainline, following our normal upstreaming
> process.
>
> I have modified the subject and the commit message a bit.
Thanks you!
>
> --
> Cheers,
> Luca.
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-17 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 9:02 [PATCH] iwlwifi: acpi: Use kmemdup rather than duplicating its implementation in iwl_parse_nvm_mcc_info YueHaibing
2018-10-17 7:25 ` Luciano Coelho
2018-10-17 7:48 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).