From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB65C3A59D for ; Thu, 22 Aug 2019 06:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFD6423400 for ; Thu, 22 Aug 2019 06:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731180AbfHVG6v (ORCPT ); Thu, 22 Aug 2019 02:58:51 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:56364 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731064AbfHVG6u (ORCPT ); Thu, 22 Aug 2019 02:58:50 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i0h3X-0000g0-Qr; Thu, 22 Aug 2019 08:58:47 +0200 Message-ID: Subject: Re: Implementing Mikrotik IE From: Johannes Berg To: Josef Miegl , Sebastian Gottschall Cc: linux-wireless Date: Thu, 22 Aug 2019 08:58:47 +0200 In-Reply-To: References: <20190815152844.k5mmddvbwrohkzr6@pepin-laptop.localdomain> <3a079683-6f57-3b42-f909-90c46e14f14f@newmedia-net.de> <20190816111044.4ntizgmpa3twbzcg@pepin-laptop.localdomain> <20190816113818.ohktykc4fyetzyvq@pepin-laptop.localdomain> <9985fddfb059640f36665efc9c1ef2dc0bdb7662.camel@sipsolutions.net> <8ec8202e-ca07-3594-5873-5b282d553711@newmedia-net.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2019-08-22 at 01:57 +0200, Josef Miegl wrote: > On August 20, 2019 2:36:21 PM GMT+02:00, Sebastian Gottschall wrote: > > i know. thats why i never even tried to contribute it upstream. but > > from > > hostapd side it was more complicated than just hacking mac80211 > > and from stations a second mod for wpa_supplicant would be needed and > > since the dd-wrt webgui just uses nl80211 to show the station table > > its more comportable and takes less code just todo it within the driver > > i there is special interest in it i could of course try to clean it up > > and make a upstream patch out of it > > I don't think something like Mikrotiks IE belongs to hostapd. The > cleanest solution is probably parsing the IE and generating the IE for > hostapd with an external tool, that can the dd-wrt GUI then use. I've > made a simple C program for this, can share if you want. Sebastian was talking about yet another case - namely recording it for the stations, to be able to show it. I guess hostapd could be made to just generally record *all* the association request IEs that a station sent and make those available over the control interface. Alternatively, you could have another application just listen to nl80211 events, I guess. Or even the kernel could capture *all*, but I don't see why we'd waste unpageable kernel memory for it. johannes