* [PATCH 11/11] net: brcmfmac: constify pci_device_id.
@ 2017-07-17 18:16 Arvind Yadav
2017-07-17 19:21 ` Arend van Spriel
2017-07-28 15:04 ` [11/11] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-07-17 18:16 UTC (permalink / raw)
To: arend.vanspriel, kvalo, hante.meuleman, franky.lin, wright.feng
Cc: netdev, linux-kernel, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index f878706..e6e9b00 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -1951,7 +1951,7 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = {
BRCM_PCIE_VENDOR_ID_BROADCOM, dev_id,\
subvend, subdev, PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, 0 }
-static struct pci_device_id brcmf_pcie_devid_table[] = {
+static const struct pci_device_id brcmf_pcie_devid_table[] = {
BRCMF_PCIE_DEVICE(BRCM_PCIE_4350_DEVICE_ID),
BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.
2017-07-17 18:16 [PATCH 11/11] net: brcmfmac: constify pci_device_id Arvind Yadav
@ 2017-07-17 19:21 ` Arend van Spriel
2017-07-28 15:04 ` [11/11] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2017-07-17 19:21 UTC (permalink / raw)
To: Arvind Yadav, kvalo, hante.meuleman, franky.lin, wright.feng
Cc: netdev, linux-kernel, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list
On 17-07-17 20:16, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index f878706..e6e9b00 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -1951,7 +1951,7 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = {
> BRCM_PCIE_VENDOR_ID_BROADCOM, dev_id,\
> subvend, subdev, PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, 0 }
>
> -static struct pci_device_id brcmf_pcie_devid_table[] = {
> +static const struct pci_device_id brcmf_pcie_devid_table[] = {
> BRCMF_PCIE_DEVICE(BRCM_PCIE_4350_DEVICE_ID),
> BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
> BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [11/11] brcmfmac: constify pci_device_id
2017-07-17 18:16 [PATCH 11/11] net: brcmfmac: constify pci_device_id Arvind Yadav
2017-07-17 19:21 ` Arend van Spriel
@ 2017-07-28 15:04 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-07-28 15:04 UTC (permalink / raw)
To: Arvind Yadav
Cc: arend.vanspriel, hante.meuleman, franky.lin, wright.feng, netdev,
linux-kernel, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
e66d70b789d1 brcmfmac: constify pci_device_id
--
https://patchwork.kernel.org/patch/9845919/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-28 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 18:16 [PATCH 11/11] net: brcmfmac: constify pci_device_id Arvind Yadav
2017-07-17 19:21 ` Arend van Spriel
2017-07-28 15:04 ` [11/11] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).