From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Alexander Wetzel <alexander@wetzel-home.de>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-kernel@vger.kernel.org, johannes.berg@intel.com,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: ieee80211_handle_wake_tx_queue and dynamic ps regression
Date: Tue, 10 Jan 2023 19:35:22 +0000 [thread overview]
Message-ID: <aace6523-0941-903e-6b80-399dc1cfc751@nexus-software.ie> (raw)
In-Reply-To: <53b23ee9-a333-120e-8b58-cfa3a9bdaefc@wetzel-home.de>
On 10/01/2023 15:43, Alexander Wetzel wrote:
>>
>
> Looks like the the commit
> https://patchwork.kernel.org/project/linux-wireless/patch/20221230121850.218810-1-alexander@wetzel-home.de/
> has a good chance to solve the issue:
>
> 1) Queues are stopped due to PS
> 2) Then there is a TX attempt. But due to the (PS) queue stop
> wake_tx_push_queue() aborts the queue run
> 3) Then we hit the bug the patch fixes: The queue is not marked to
> have pending packets and thus packets on it are not transmitted.
>
> Packets get only send when you happen to try tx when the queue is
> operational. (And then you will get all the packets sitting in the queue.)
>
> Does that make sense? And more crucial, is the patch fixing that for you?
Ok works for me.
Good job.
---
bod
next prev parent reply other threads:[~2023-01-10 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19015168-c747-17b7-f0ae-9d2ee27d221c@linaro.org>
2023-01-10 12:44 ` ieee80211_handle_wake_tx_queue and dynamic ps regression Bryan O'Donoghue
2023-01-10 14:47 ` Bryan O'Donoghue
2023-01-10 15:23 ` Alexander Wetzel
2023-01-10 15:43 ` Alexander Wetzel
2023-01-10 19:35 ` Bryan O'Donoghue [this message]
2023-01-13 12:17 ` Linux kernel regression tracking (#update)
2023-01-10 16:06 ` Bryan O'Donoghue
2023-01-10 13:08 ` Linux kernel regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aace6523-0941-903e-6b80-399dc1cfc751@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=alexander@wetzel-home.de \
--cc=bryan.odonoghue@linaro.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).