From: Mad Horse <equu@openmail.cc>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: lpieralisi@kernel.org, toke@toke.dk, kvalo@kernel.org,
linux-pci@vger.kernel.org, robh@kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Edward Chow <equu@openmail.cc>
Subject: Re: [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data
Date: Wed, 1 Feb 2023 11:02:59 +0800 [thread overview]
Message-ID: <ab8ff515-19ec-fe3f-0237-c30275e9744d@openmail.cc> (raw)
In-Reply-To: <20230117194614.GA135447@bhelgaas>
在 2023/1/18 03:46, Bjorn Helgaas 写道:
> On Tue, Jan 17, 2023 at 05:27:46PM +0800, Edward Chow wrote:
>> Loading calibration data from an OF device tree node not declared
>> compatible with the device (e.g. a PCI device with calibration data
>> from corresponding DT node gets replaced, so the newly installed
>> device become incompatible with the node) or driver may lead to fatal
>> result, e.g. kernel panic.
> Please include a link to a bug report and include a few lines of the
> oops or panic directly in the commit log so when users see this
> problem, they can search for the text and possibly find this fix.
>
>> The driver should check whether the DT node corresponding to the
>> device compatible with it, and load calibration data only from
>> compatible node.
> If you read this commit log carefully, it doesn't actually say what
> this patch *does*. It has some background and this assertion about
> what drivers *should* do, but it doesn't say what this patch does.
>
> Suggest structure like this (flesh out with the relevant DT property
> names, etc):
>
> For PCI ath9k devices, load calibration data only if there is a DT
> node corresponding to the device with XXX ...
>
> More details: https://chris.beams.io/posts/git-commit/
>
Thanks for pointing it out. The commit log of the last two patch has been reworded with required content, and sent to the current thread earlier.
next prev parent reply other threads:[~2023-02-01 3:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ea4e2fed-383d-829d-8a2a-9239768ccd94@openmail.cc>
2023-01-17 9:27 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Edward Chow
2023-01-17 9:27 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data Edward Chow
2023-01-17 19:46 ` Bjorn Helgaas
2023-02-01 3:02 ` Mad Horse [this message]
2023-02-01 21:43 ` Bjorn Helgaas
2023-02-02 4:18 ` [PATCH v2 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-02 4:18 ` [PATCH v2 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-02 4:18 ` [PATCH v2 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-02 4:18 ` [PATCH v2 3/3] wifi: ath10k: only load compatible " equu
2023-02-02 7:26 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-02 7:55 ` [PATCH v3 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 8:23 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 9:56 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 11:38 ` kernel test robot
2023-02-03 8:37 ` [PATCH v4 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-03 8:37 ` [PATCH v4 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 8:37 ` [PATCH v4 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 8:37 ` [PATCH v4 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 10:48 ` [PATCH v5 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-03 10:48 ` [PATCH v5 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 10:48 ` [PATCH v5 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 10:48 ` [PATCH v5 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 15:57 ` Rob Herring
2023-02-03 17:15 ` equu
2023-02-03 18:45 ` Rob Herring
2023-02-04 4:26 ` equu
2023-02-09 4:50 ` [PATCH v6 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-09 4:50 ` [PATCH v6 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-09 4:50 ` [PATCH v6 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-09 4:50 ` [PATCH v6 3/3] wifi: ath10k: only load compatible " equu
2023-02-09 16:09 ` Rob Herring
2023-01-17 9:28 ` [PATCH " Edward Chow
2023-01-17 10:01 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Mad Horse
2023-01-17 10:02 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data Mad Horse
2023-01-17 10:02 ` [PATCH 3/3] wifi: ath10k: only load compatible " Mad Horse
2023-01-17 10:29 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Mad Horse
2023-01-21 10:00 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data persmule
2023-01-21 10:06 ` [PATCH 3/3] wifi: ath10k: only load compatible " persmule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8ff515-19ec-fe3f-0237-c30275e9744d@openmail.cc \
--to=equu@openmail.cc \
--cc=ath10k@lists.infradead.org \
--cc=helgaas@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).