From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Lin Ian (CSSITB CSS ICW SW WFS / EE)" <ian.lin-ee@infineon.com>,
linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
Chi-Hsien.Lin@infineon.com, Wright.Feng@infineon.com,
Double.Lo@infineon.com
Subject: Re: [PATCH] brcmfmac: add CYW43570 PCIE device
Date: Thu, 25 Nov 2021 10:44:19 +0100 [thread overview]
Message-ID: <ac096741-70d1-9ecd-00fe-9182ace525d3@broadcom.com> (raw)
In-Reply-To: <ca0b63d7-b50b-748e-1a3f-e07464eb3949@infineon.com>
[-- Attachment #1: Type: text/plain, Size: 2871 bytes --]
On 11/25/2021 10:29 AM, Lin Ian (CSSITB CSS ICW SW WFS / EE) wrote:
>
>
> On 11/23/2021 8:32 PM, Arend van Spriel wrote:
>> On November 23, 2021 7:24:32 AM "Lin Ian (CSSITB CSS ICW SW WFS / EE)"
>> <ian.lin-ee@infineon.com> wrote:
>>
>>> From: Soontak Lee <soontak.lee@cypress.com>
>>>
>>> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
>>> It is BT/WIFI combo.
>>>
>>> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
>>> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>>
>> Missing signoff
>>
>>> Jira:SWLINUX-1213
>>
>> Meaningless to the public so remove it when submitting to the community.
> I will send a new patch mail that modified the commit message, thank you.
great.
>>> ---
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 +
>>> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>>> 2 files changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> index 8b149996fc00..ceeb1f10752a 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> @@ -2106,6 +2106,7 @@ static const struct pci_device_id
>>> brcmf_pcie_devid_table[] = {
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
>>> + BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
>>> BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
>>> diff --git
>>> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> index 9d81320164ce..3bbe2388ec54 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> @@ -71,6 +71,7 @@
>>> #define BRCM_PCIE_4356_DEVICE_ID 0x43ec
>>> #define BRCM_PCIE_43567_DEVICE_ID 0x43d3
>>> #define BRCM_PCIE_43570_DEVICE_ID 0x43d9
>>> +#define BRCM_PCIE_43570_RAW_DEVICE_ID 0xaa31
>>
>> It is just a name, but what does RAW mean here? Also 0xaa31 is 43569
>> in decimal. Is this really a valid device ID or is this an
>> unprogrammed device (without valid devid in OTP).
> It's a unprogrammed device, basically 0xaa31 is the id with blank OTP.
So do we expect linux end-users to come across such a device. As far as
I know a device with unprogrammed OTP will use the chip id as the PCI
devid. If this is needed to enable development with unprogrammed devices
I would suggest to have these under Kconfig option.
Regards,
Arend
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2021-11-25 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 6:24 [PATCH] brcmfmac: add CYW43570 PCIE device Lin Ian (CSSITB CSS ICW SW WFS / EE)
2021-11-23 12:32 ` Arend van Spriel
2021-11-25 9:29 ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
2021-11-25 9:44 ` Arend van Spriel [this message]
2021-11-29 7:39 ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac096741-70d1-9ecd-00fe-9182ace525d3@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Chi-Hsien.Lin@infineon.com \
--cc=Double.Lo@infineon.com \
--cc=Wright.Feng@infineon.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=ian.lin-ee@infineon.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).