From: Johannes Berg <johannes@sipsolutions.net>
To: Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Chung-Hsien Hsu <stanley.hsu@cypress.com>
Subject: Re: [PATCH 3/4] nl80211: support SAE authentication offload in AP mode
Date: Thu, 30 Jul 2020 16:55:02 +0200 [thread overview]
Message-ID: <accbebe93a2c851080b3544759eb5d17c15e646d.camel@sipsolutions.net> (raw)
In-Reply-To: <20200623134938.39997-4-chi-hsien.lin@cypress.com> (sfid-20200623_155000_965089_06BEA254)
On Tue, 2020-06-23 at 08:49 -0500, Chi-Hsien Lin wrote:
> From: Chung-Hsien Hsu <stanley.hsu@cypress.com>
>
> Add support for SAE authentication offload in AP mode.
It seems to me you need a new feature flag for this, just like in the
PSK case, because brcmfmac in fact already sets this, and in fact as we
can see in patch 4 it would now set it in two places depending on
*different* firmware support conditions ... that may be OK for the
firmware right now, but it still doesn't really make much sense.
Please change to add another flag here.
johannes
next prev parent reply other threads:[~2020-07-30 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:49 [PATCH 0/4] nl80211: add support for WPA/WPA2-PSK 4-way handshake and SAE offload in AP mode Chi-Hsien Lin
2020-06-23 13:49 ` [PATCH 1/4] nl80211: support 4-way handshake offloading for WPA/WPA2-PSK " Chi-Hsien Lin
2020-07-30 14:52 ` Johannes Berg
2020-06-23 13:49 ` [PATCH 2/4] brcmfmac: " Chi-Hsien Lin
2020-06-23 13:49 ` [PATCH 3/4] nl80211: support SAE authentication offload " Chi-Hsien Lin
2020-07-30 14:55 ` Johannes Berg [this message]
2020-06-23 13:49 ` [PATCH 4/4] brcmfmac: " Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accbebe93a2c851080b3544759eb5d17c15e646d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stanley.hsu@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).