From: Enrico Mioso <mrkiko.rs@gmail.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Daniel Golle <daniel@makrotopia.org>,
Arnd Bergmann <arnd@arndb.de>, John Crispin <john@phrozen.org>,
nbd@nbd.name
Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?
Date: Tue, 19 Dec 2017 13:43:11 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.21.99.1712191341570.2555@localhost.localdomain> (raw)
In-Reply-To: <20171219122707.GA2672@redhat.com>
I am going to test this on a LEDE build.
Should I leave the mmio workaround patch applied as per OpenWRT default, or should I leave it off ?
I'll leave it off by default.
thank you again,
Enrico
On Tue, 19 Dec 2017, Stanislaw Gruszka wrote:
> Date: Tue, 19 Dec 2017 13:27:07
> From: Stanislaw Gruszka <sgruszka@redhat.com>
> To: Enrico Mioso <mrkiko.rs@gmail.com>
> Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
> Daniel Golle <daniel@makrotopia.org>, Arnd Bergmann <arnd@arndb.de>,
> John Crispin <john@phrozen.org>, nbd@nbd.name
> Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping
> frame due to full tx queue...?
>
> On Mon, Dec 18, 2017 at 04:21:42PM +0100, Stanislaw Gruszka wrote:
>> Hi
>>
>> On Sat, Dec 16, 2017 at 07:33:47PM +0100, Enrico Mioso wrote:
>>> I tested the Archer MR200 device removing the patch as you suggested:
>>> package/kernel/mac80211/patches/600-23-rt2x00-rt2800mmio-add-a-workaround-for-spurious-TX_F.patch
>>> ... the error still appears, but the driver is still working as of now.
>>> Here - reporting my dmesg
>>> [ 819.060392] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
>>> [ 819.069900] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
>
> Please test two patches I posted today:
> https://marc.info/?l=linux-wireless&m=151368325114059&w=2
> https://marc.info/?l=linux-wireless&m=151368325914062&w=2
>
> If they do not work, please try the queue->threshold change.
>
> Thanks
> Stanislaw
>
>
>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
>> index a2c1ca5c76d1..9e65b8f285e9 100644
>> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
>> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
>> @@ -1224,7 +1224,7 @@ static void rt2x00queue_init(struct rt2x00_dev *rt2x00dev,
>>
>> rt2x00dev->ops->queue_init(queue);
>>
>> - queue->threshold = DIV_ROUND_UP(queue->limit, 10);
>> + queue->threshold = DIV_ROUND_UP(queue->limit, 8);
>> }
>>
>> int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)
>
next prev parent reply other threads:[~2017-12-19 12:43 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 20:51 ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...? Enrico Mioso
2017-12-13 15:20 ` Stanislaw Gruszka
2017-12-16 18:33 ` Enrico Mioso
2017-12-18 15:21 ` Stanislaw Gruszka
2017-12-19 12:27 ` Stanislaw Gruszka
2017-12-19 12:39 ` Enrico Mioso
2017-12-19 12:43 ` Enrico Mioso [this message]
2017-12-19 12:54 ` Stanislaw Gruszka
2017-12-19 13:25 ` Enrico Mioso
2017-12-20 17:49 ` Enrico Mioso
2017-12-21 14:25 ` Stanislaw Gruszka
2017-12-24 12:19 ` Enrico Mioso
2018-01-03 11:35 ` Stanislaw Gruszka
2018-01-03 14:04 ` Enrico Mioso
[not found] ` <CAKR_QVLRwAA0NJSarX46J4A8XSp8h5SuTEtSBQ4ydpEPh_-aUw@mail.gmail.com>
2018-01-22 5:45 ` Enrico Mioso
2018-01-23 13:22 ` Stanislaw Gruszka
2018-01-24 5:14 ` Enrico Mioso
2018-01-24 8:18 ` Enrico Mioso
2018-01-24 10:03 ` Stanislaw Gruszka
2018-03-01 15:30 ` Daniel Golle
2018-03-02 19:13 ` Enrico Mioso
2018-03-07 12:27 ` Stanislaw Gruszka
2018-03-07 12:29 ` Stanislaw Gruszka
2018-03-23 7:51 ` Mathias Kresin
2018-03-26 10:35 ` Stanislaw Gruszka
2018-03-27 7:46 ` Mathias Kresin
2018-03-27 17:18 ` Stanislaw Gruszka
2018-03-27 17:43 ` Daniel Golle
2018-03-28 4:14 ` Enrico Mioso
[not found] ` <CAOt++SeSQ2j1KuVkbqt77LfznXN7JV0Lx5O8d7-m2VBrz8=85g@mail.gmail.com>
2018-03-29 5:13 ` Enrico Mioso
2018-03-30 14:41 ` Enrico Mioso
2018-03-30 14:44 ` Enrico Mioso
[not found] ` <MWHPR02MB3326233159B021143D7278F5D4A10@MWHPR02MB3326.namprd02.prod.outlook.com>
2018-03-30 17:33 ` Enrico Mioso
[not found] ` <CAOt++SeLh_NxcmM=YEMQSv4y9PabS_dT7k4yTxUiqXbac-=iUQ@mail.gmail.com>
2018-04-17 13:55 ` Enrico Mioso
2018-04-17 13:56 ` Jamie Stuart
2018-04-17 13:57 ` Enrico Mioso
2018-04-17 19:42 ` Stanislaw Gruszka
[not found] ` <CAOt++SeNt=4RUTvAR1y_WjC=a-YyYa3YBSmoAmv+7uK71U+3+A@mail.gmail.com>
2018-05-28 12:50 ` Stanislaw Gruszka
2018-05-28 13:54 ` Daniel Golle
2018-08-15 11:40 ` Stanislaw Gruszka
2018-08-15 22:35 ` Daniel Golle
2018-08-16 11:01 ` Stanislaw Gruszka
[not found] ` <DM5PR02MB365669D5E9F2DE20DAE4CB7AD43E0@DM5PR02MB3656.namprd02.prod.outlook.com>
2018-08-18 16:08 ` Daniel Golle
2018-08-20 12:20 ` Stanislaw Gruszka
2018-08-24 13:02 ` Stanislaw Gruszka
2018-03-28 18:13 ` Stanislaw Gruszka
2018-03-07 15:47 ` Jamie Stuart
2018-03-07 23:30 ` Enrico Mioso
2018-03-07 23:31 ` Enrico Mioso
2018-03-08 9:39 ` Stanislaw Gruszka
2018-03-08 14:28 ` Enrico Mioso
2018-01-23 13:20 ` Stanislaw Gruszka
2017-12-26 17:20 ` Enrico Mioso
2018-01-03 11:45 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.99.1712191341570.2555@localhost.localdomain \
--to=mrkiko.rs@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=johannes.berg@intel.com \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).