From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset
Date: Tue, 8 Aug 2017 14:53:25 +0800 [thread overview]
Message-ID: <b13203ce-e111-09ac-0339-c79d6767c752@cypress.com> (raw)
In-Reply-To: <59885CB5.2040007@broadcom.com>
On 08/07/2017 8:27, Arend van Spriel wrote:
> On 8/3/2017 11:37 AM, Wright Feng wrote:
>> From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>>
>> Add support for CYW4373 SDIO/USB chipset.
>> CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support.
>> It's a WiFi/BT combo device.
>
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>> ---
>> v2: add new chip(4737) info in commit message
>
> comment below...
>
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 1 +
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 2 ++
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 +++-
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 9
>> ++++++++-
>> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 3 +++
>> include/linux/mmc/sdio_ids.h | 1 +
>> 6 files changed, 18 insertions(+), 2 deletions(-)
>>
>
> [...]
>
>> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
>> index b733eb4..abacd54 100644
>> --- a/include/linux/mmc/sdio_ids.h
>> +++ b/include/linux/mmc/sdio_ids.h
>> @@ -39,6 +39,7 @@
>> #define SDIO_DEVICE_ID_BROADCOM_43455 0xa9bf
>> #define SDIO_DEVICE_ID_BROADCOM_4354 0x4354
>> #define SDIO_DEVICE_ID_BROADCOM_4356 0x4356
>> +#define SDIO_DEVICE_ID_CYPRESS_4373 0x4373
>
> So is there no specific Cypress SDIO vendor ID?
There is no Cypress SDIO vid. I believe the legacy chips 4343w ...etc.
shipped are still using BRCM SDIO vid. Also, 4373 project was initiated
in Broadcom so the default id was set to the Broadcom id. Will it a
requirement to add Cypress vid here?
>
>> #define SDIO_VENDOR_ID_INTEL 0x0089
>> #define SDIO_DEVICE_ID_INTEL_IWMC3200WIMAX 0x1402
>>
>
> .
>
next prev parent reply other threads:[~2017-08-08 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 9:37 [PATCH v2 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode Wright Feng
2017-08-03 9:37 ` [PATCH v2 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset Wright Feng
2017-08-07 12:27 ` Arend van Spriel
2017-08-08 6:53 ` Chi-Hsien Lin [this message]
2017-08-08 9:36 ` Arend van Spriel
2017-08-03 9:37 ` [PATCH v2 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled Wright Feng
2017-08-03 10:05 ` Kalle Valo
2017-08-07 12:33 ` Arend van Spriel
2017-08-03 10:04 ` [PATCH v2 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode Kalle Valo
2017-08-07 12:24 ` Arend van Spriel
2017-08-08 11:51 ` [v2, " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13203ce-e111-09ac-0339-c79d6767c752@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).