From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC52C433B4 for ; Mon, 12 Apr 2021 08:09:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6289C6120B for ; Mon, 12 Apr 2021 08:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237251AbhDLIKK (ORCPT ); Mon, 12 Apr 2021 04:10:10 -0400 Received: from lpdvacalvio01.broadcom.com ([192.19.229.182]:42742 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237244AbhDLIKJ (ORCPT ); Mon, 12 Apr 2021 04:10:09 -0400 Received: from bld-lvn-bcawlan-34.lvn.broadcom.net (bld-lvn-bcawlan-34.lvn.broadcom.net [10.75.138.137]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id C02D6E5; Mon, 12 Apr 2021 01:09:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com C02D6E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1618214991; bh=yCmWe9dBWtm2jBQb8Zp5DEdyYQSVpG8V2elCrTJrN/8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZHWW58J37yln06ZUkr0Ur/8G5b/qgWLfUUmlgxfitW2VCxTbczMOs88Ntu22uu0iM OInheEO4rSRHBd+G6Fn/j7nvpzy+CRi4I5efyWFyfy7iHyHIzgtXSrUaVeGjRMRxkW uuja/JO4bALP55eNnPw2DrQ0axrY9hSIWrrUgh6Q= Received: from [10.230.42.155] (unknown [10.230.42.155]) by bld-lvn-bcawlan-34.lvn.broadcom.net (Postfix) with ESMTPSA id 2711F1874BD; Mon, 12 Apr 2021 01:09:45 -0700 (PDT) Subject: Re: [PATCH 2/2] brcmfmac: support parse country code map from DT To: Shawn Guo , Kalle Valo Cc: Rob Herring , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20210408113022.18180-1-shawn.guo@linaro.org> <20210408113022.18180-3-shawn.guo@linaro.org> From: Arend van Spriel Message-ID: Date: Mon, 12 Apr 2021 10:09:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210408113022.18180-3-shawn.guo@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 08-04-2021 13:30, Shawn Guo wrote: > With any regulatory domain requests coming from either user space or > 802.11 IE (Information Element), the country is coded in ISO3166 > standard. It needs to be translated to firmware country code and > revision with the mapping info in settings->country_codes table. > Support populate country_codes table by parsing the mapping from DT. comment below, but you may add... Reviewed-by: Arend van Spriel > Signed-off-by: Shawn Guo > --- > .../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > index a7554265f95f..ea5c7f434c2c 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c [...] > @@ -47,6 +96,10 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, > !of_device_is_compatible(np, "brcm,bcm4329-fmac")) > return; > > + ret = brcmf_of_get_country_codes(dev, settings); > + if (ret) > + dev_warn(dev, "failed to get OF country code map\n"); First of all I prefer to use brcmf_err and add ret value to the print message " (err=%d)\n". Another thing is that this mapping is not only applicable for SDIO devices so you may consider doing this for other bus types as well which requires a bit more rework here.