From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B9AC432C0 for ; Mon, 2 Dec 2019 18:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D67902070A for ; Mon, 2 Dec 2019 18:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="JAGV8C+R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbfLBSRc (ORCPT ); Mon, 2 Dec 2019 13:17:32 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:39014 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727721AbfLBSRc (ORCPT ); Mon, 2 Dec 2019 13:17:32 -0500 Received: from [192.168.100.195] (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 1544F137531; Mon, 2 Dec 2019 10:17:31 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 1544F137531 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1575310651; bh=/2PhJ5xFWBl4QKp0sJThhBjgqj8x5G6dX5WbrLLGJX0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JAGV8C+RWwb5o5IPTnPBPM+9aoTmOfZqCQelhV3/V4iGkHhD55Z+syJ14fM89ZxNV 7GqV228r75AOkhy/jxschYh8L9Y5clW7j8FtAnA4XjPrb8ePP6/vZI+NK39ejudH7/ yVBOE/SvAwdKxwdn1syOVQR1iOjl0+0JS/7yNuPQ= Subject: Re: [PATCH] ath10k: set WMI_PEER_AUTHORIZE after a firmware crash To: Justin Capella , Kalle Valo Cc: Wen Gong , ath10k , linux-wireless@vger.kernel.org References: <0101016eaadee57a-54500c6d-4751-423f-8bab-5acd8fad2175-000000@us-west-2.amazonses.com> <0101016eb61d9520-b0306a23-c9b9-4b57-b708-9f80ac47eef1-000000@us-west-2.amazonses.com> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Mon, 2 Dec 2019 10:17:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 12/1/19 8:45 PM, Justin Capella wrote: > Are there security concerns here? Was the peer known to be authorized > beforehand? Would it be better to just trash the peer in the event of > a fw crash? I think you should completely re-associate the peer(s) when firmware crashes. The driver does not cache all possible changes, so it cannot exactly rebuild the config to the previous state. Thanks, Ben > > On Thu, Nov 28, 2019 at 11:46 PM Kalle Valo wrote: >> >> Wen Gong wrote: >> >>> After the firmware crashes ath10k recovers via ieee80211_reconfig(), >>> which eventually leads to firmware configuration and including the >>> encryption keys. However, because there is no new auth/assoc and >>> 4-way-handshake, and firmware set the authorize flag after >>> 4-way-handshake, so the authorize flag in firmware is not set in >>> firmware without 4-way-handshake. This will lead to a failure of data >>> transmission after recovery done when using encrypted connections like >>> WPA-PSK. Set authorize flag after installing keys to firmware will fix >>> the issue. >>> >>> This was noticed by testing firmware crashing using simulate_fw_crash >>> debugfs file. >>> >>> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00007-QCARMSWP-1. >>> >>> Signed-off-by: Wen Gong >>> Signed-off-by: Kalle Valo >> >> Patch applied to ath-next branch of ath.git, thanks. >> >> 382e51c139ef ath10k: set WMI_PEER_AUTHORIZE after a firmware crash >> >> -- >> https://patchwork.kernel.org/patch/11263357/ >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >> > -- Ben Greear Candela Technologies Inc http://www.candelatech.com