From: Aiden Leong <aiden.leong@aibsd.com>
To: "Greenman, Gregory" <gregory.greenman@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH 1/2] iwlwifi: pcie: add support for AX101NGW
Date: Mon, 2 Jan 2023 22:32:38 +0800 [thread overview]
Message-ID: <b5b67842-17a2-f2b8-3c58-b6242b77e5b7@aibsd.com> (raw)
In-Reply-To: <b1e7aabf9f1543fda0919a41ca97ead23b298225.camel@intel.com>
1. I know nothing about what `tx_with_siso_diversity` is. It's just a
hardware flag to me. Main line.
2. I have the real device. Tested. Two photos was sent to Luca Coelho as
well.
3. /drivers/net/wireless/intel/iwlwifi/pcie/drv.c#L623
> IWL_DEV_INFO(0x4DF0, 0x1651, killer1650s_2ax_cfg_qu_b0_hr_b0, NULL),
The device I have is 0x4DF0, 0x0244. They share the same device ID.
4. I have narrowed down my code with _mac_step, _rf_type, _rf_id,
_no_160 and _cores, so it should be safe to other devices.
Happy New Year
Aiden
On 2023/1/2 21:32, Greenman, Gregory wrote:
> On Mon, 2023-01-02 at 10:40 +0800, Aiden Leong wrote:
>> AX101NGW(0x4DF0, 0x0244) should have tx_with_siso_diversity unset.
> Why it should be unset? Which kernel do you have?
> Commit 3f910a25839b13436bf0a22186f1698b23eafb91 added AX101 device.
>
>> Signed-off-by: Aiden Leong <aiden.leong@aibsd.com>
>> ---
>> Ref Commit: 9352ed0165ff4313ab340c979446c3d64c531f7a
>> Tested on my own device.
>> ---
>> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> index 99768d6a6032..a46df1320372 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
>> @@ -986,6 +986,11 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
>> iwl_qu_c0_hr_b0, iwl_ax201_name),
>>
>> /* QuZ */
>> + _IWL_DEV_INFO(IWL_CFG_ANY, IWL_CFG_ANY,
>> + IWL_CFG_MAC_TYPE_QUZ, SILICON_B_STEP,
>> + IWL_CFG_RF_TYPE_HR1, IWL_CFG_RF_ID_HR1,
>> + IWL_CFG_NO_160, IWL_CFG_CORES_BT, IWL_CFG_NO_CDB, IWL_CFG_NO_JACKET,
>> + iwl_cfg_quz_a0_hr_b0, iwl_ax101_name),
>> _IWL_DEV_INFO(IWL_CFG_ANY, IWL_CFG_ANY,
>> IWL_CFG_MAC_TYPE_QUZ, IWL_CFG_ANY,
>> IWL_CFG_RF_TYPE_HR1, IWL_CFG_ANY,
next prev parent reply other threads:[~2023-01-02 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 2:40 [PATCH 1/2] iwlwifi: pcie: add support for AX101NGW Aiden Leong
2023-01-02 13:32 ` Greenman, Gregory
2023-01-02 14:32 ` Aiden Leong [this message]
2023-01-05 6:39 ` Greenman, Gregory
2023-01-05 8:41 ` Aiden Leong
2023-01-19 15:22 ` Greenman, Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b67842-17a2-f2b8-3c58-b6242b77e5b7@aibsd.com \
--to=aiden.leong@aibsd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.greenman@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).