linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()
@ 2017-05-17 16:22 SF Markus Elfring
  2017-05-17 20:46 ` Michael Büsch
  2017-05-24 13:47 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2017-05-17 16:22 UTC (permalink / raw)
  To: linux-wireless, Michael Büsch; +Cc: LKML, kernel-janitors, Wolfram Sang

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 17 May 2017 18:12:16 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/ssb/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index d1a750760cf3..65420a9f0e82 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)
 
 		devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
 		if (!devwrap) {
-			ssb_err("Could not allocate device\n");
 			err = -ENOMEM;
 			goto error;
 		}
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()
  2017-05-17 16:22 [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() SF Markus Elfring
@ 2017-05-17 20:46 ` Michael Büsch
  2017-05-24 13:47 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2017-05-17 20:46 UTC (permalink / raw)
  To: SF Markus Elfring; +Cc: linux-wireless, LKML, kernel-janitors, Wolfram Sang

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Wed, 17 May 2017 18:22:49 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 17 May 2017 18:12:16 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/ssb/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index d1a750760cf3..65420a9f0e82 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)
>  
>  		devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
>  		if (!devwrap) {
> -			ssb_err("Could not allocate device\n");
>  			err = -ENOMEM;
>  			goto error;
>  		}


This looks good.

Acked-by: Michael Büsch <m@bues.ch>


-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ssb: Delete an error message for a failed memory allocation in ssb_devices_register()
  2017-05-17 16:22 [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() SF Markus Elfring
  2017-05-17 20:46 ` Michael Büsch
@ 2017-05-24 13:47 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-05-24 13:47 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: linux-wireless, Michael Büsch, LKML, kernel-janitors, Wolfram Sang

SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 17 May 2017 18:12:16 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> Acked-by: Michael Büsch <m@bues.ch>

Patch applied to wireless-drivers-next.git, thanks.

c6c092dcb21e ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

-- 
https://patchwork.kernel.org/patch/9731583/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-24 13:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 16:22 [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register() SF Markus Elfring
2017-05-17 20:46 ` Michael Büsch
2017-05-24 13:47 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).