From: Antonio Quartulli <antonio.quartulli@kaiwoo.ai>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix offchannel tx failure when no ath10k_mac_tx_frm_has_freq
Date: Mon, 30 Sep 2019 16:29:32 +0200 [thread overview]
Message-ID: <ba256006-b42b-0dee-4eb7-093da5885341@kaiwoo.ai> (raw)
In-Reply-To: <1508284992-3574-1-git-send-email-greearb@candelatech.com>
Hi,
On 18/10/2017 02:03, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This bug appears to have been added between 4.0 (which works for us),
> and 4.4, which does not work.
>
> I think this is because the tx-offchannel logic gets in a loop when
> ath10k_mac_tx_frm_has_freq(ar) is false, so pkt is never actually
> sent to the firmware for transmit.
>
> This patch fixes the problem on 4.9 for me, and now HS20 clients
> can work again with my firmware.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
I have been struggling to send offchannels mgmt frames since a while, as
I was always getting:
[18099.253732] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3780
[18102.293686] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3780
[18105.333653] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3780
[18108.373712] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3780
[18111.413687] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e36c0
[18114.453726] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3f00
[18117.493773] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e36c0
[18120.533631] ath10k_pci 0000:01:00.0: timed out waiting for offchannel
skb cf0e3f00
After digging through the ath10k patchwork I have found this patch which
touches exactly the code I was trying to debug.
After applying this set of changes, I can confirm that sending
offchannel frames works again like a charm.
I have tested only one fw though: ver 10.4-3.5.3-00057.
It's a bummer that this trivial but critical patch is not yet merged
upstream :-(
Tested-by: Antonio Quartulli <antonio.quartulli@kaiwoo.ai>
--
Antonio Quartulli
Kaiwoo.ai
next prev parent reply other threads:[~2019-09-30 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 0:03 [PATCH] ath10k: Fix offchannel tx failure when no ath10k_mac_tx_frm_has_freq greearb
2019-09-30 14:29 ` Antonio Quartulli [this message]
2019-10-02 6:05 ` Kalle Valo
2019-10-02 6:55 ` Antonio Quartulli
2019-10-02 17:17 ` [PATCH] ath10k: Fix offchannel tx failure when noath10k_mac_tx_frm_has_freq Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba256006-b42b-0dee-4eb7-093da5885341@kaiwoo.ai \
--to=antonio.quartulli@kaiwoo.ai \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).