RE: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame

From: Pkshih <pkshih@realtek.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	DeanKu <ku920601@realtek.com>, Bernie Huang <phhuang@realtek.com>,
	Shaofu <shaofu@realtek.com>, Steven Ting <steventing@realtek.com>,
	Kevin Yang <kevin_yang@realtek.com>
Subject: RE: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
Date: Thu, 15 Apr 2021 04:05:47 +0000	[thread overview]
Message-ID: <bd370e998b324aa18dd479e550841b99@realtek.com> (raw)
In-Reply-To: <87r1jflo7p.fsf@codeaurora.org>

> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> Behalf Of Kalle Valo
> Sent: Monday, April 12, 2021 7:47 PM
> To: Pkshih
> Cc: tony0620emma@gmail.com; linux-wireless@vger.kernel.org; DeanKu; Bernie Huang; Shaofu; Steven Ting;
> Kevin Yang
> Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
> 
> Pkshih <pkshih@realtek.com> writes:
> 
> >> -----Original Message-----
> >> From: kvalo=codeaurora.org@mg.codeaurora.org
> >> [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
> >> Behalf Of Kalle Valo
> >> Sent: Sunday, April 11, 2021 5:21 PM
> >> To: Pkshih
> >> Cc: tony0620emma@gmail.com; linux-wireless@vger.kernel.org; DeanKu;
> >> Bernie Huang; Shaofu; Steven Ting;
> >> Kevin Yang
> >> Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
> >>
> >> Ping-Ke Shih <pkshih@realtek.com> wrote:
> >>
> >> > From: Shao-Fu Cheng <shaofu@realtek.com>
> >> >
> >> > By default the driver uses the 1M and 6M rate for managemnt frames
> >> > in 2G and 5G bands respectively. But when the basic rates is configured
> >> > from the mac80211, we need to send the management frames according the
> >> > basic rates.
> >> >
> >> > This commit makes the driver use the lowest basic rates to send
> >> > the management frames and a debufs entry to enable/disable force to use
> >> > the lowest rate 1M/6M for 2.4G/5G bands.
> >> >
> >> > obtain current setting
> >> > cat /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
> >> >
> >> > force lowest rate:
> >> > echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
> >> >
> >> > Signed-off-by: Shao-Fu Cheng <shaofu@realtek.com>
> >> > Signed-off-by: Yu-Yen Ting <steventing@realtek.com>
> >> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> >>
> >> Why is a debugfs interface needed?
> >>
> >
> > By default, driver follows AP's basic rates that may be 24M and above, and
> > does association with 24M rate. If AP is far away, it may be hard to communicate
> > with 24M rate. Therefore, we add a debugfs to allow driver to send management
> > frames with low rate 6M or 1M.
> 
> debugfs is for R&D level testing and debugging, not normal user
> configuration. To me it looks like something like that should be in
> nl80211.
> 

I do not expect that the users could configure the basic rate for station by
the normal way such as nl80211. This debugfs is for debugging purpose,
not for normal user.

--
Ping-Ke