Re: [PATCH v2 12/16] iwlwifi: dbg_ini: support domain changing via debugfs

[Luca Coelho <luca@coelho.fi>]

On Wed, 2019-10-16 at 10:07 +0300, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
> 
> > From: Shahar S Matityahu <shahar.s.matityahu@intel.com>
> > 
> > Allow to change or read the debug domain bitmap at runtime via
> > fw_dbg_domain debugfs.
> > 
> > Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> 
> [...]
> 
> > +static ssize_t iwl_dbgfs_fw_dbg_domain_write(struct iwl_fw_runtime *fwrt,
> > +					     char *buf, size_t count)
> > +{
> > +	u32 new_domain;
> > +	long val;
> > +	int ret;
> > +
> > +	if (!iwl_trans_fw_running(fwrt->trans))
> > +		return -EIO;
> > +
> > +	ret = kstrtol(buf, 0, &val);
> > +	if (ret)
> > +		return ret;
> > +
> > +	new_domain = (u32)val;
> 
> Why not use kstrtou32()? Then there's no need to cast anything.

Good point, I'll fix it.

--
Luca.