From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "arnd@kernel.org" <arnd@kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Berg, Johannes" <johannes.berg@intel.com>,
"Baruch, Yaara" <yaara.baruch@intel.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"nathan@kernel.org" <nathan@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"Gottlieb, Matti" <matti.gottlieb@intel.com>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: pcie: fix constant-conversion warning
Date: Mon, 1 Nov 2021 07:32:13 +0000 [thread overview]
Message-ID: <bf9e17301c7d38e5b9f7e0e9989a7445e6dd7a3a.camel@intel.com> (raw)
In-Reply-To: <4e1abf0c252ed1f049e1be77247626af369aa5e8.camel@intel.com>
On Mon, 2021-11-01 at 09:29 +0200, Luciano Coelho wrote:
> On Sun, 2021-10-31 at 09:06 +0200, Kalle Valo wrote:
> > Arnd Bergmann <arnd@kernel.org> writes:
> >
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > clang points out a potential issue with integer overflow when
> > > the iwl_dev_info_table[] array is empty:
> > >
> > > drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion]
> > > for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) {
> > > ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> > >
> > > This is still harmless, as the loop correctly terminates, but adding
> > > an (int) cast makes that clearer to the compiler.
> > >
> > > Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Luca, can I take this to wireless-drivers? Ack?
>
> Yes, please do.
>
> Thanks.
>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
Actually, wouldn't it be simpler to change the declaration of i to be
unsigned int?
--
Luca.
next prev parent reply other threads:[~2021-11-01 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 15:42 [PATCH] iwlwifi: pcie: fix constant-conversion warning Arnd Bergmann
2021-10-31 7:06 ` Kalle Valo
2021-11-01 7:29 ` Coelho, Luciano
2021-11-01 7:32 ` Coelho, Luciano [this message]
2021-11-04 13:37 Arnd Bergmann
2021-11-10 21:38 ` Nick Desaulniers
2021-11-10 21:39 ` Nick Desaulniers
2021-11-11 7:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf9e17301c7d38e5b9f7e0e9989a7445e6dd7a3a.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=matti.gottlieb@intel.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=yaara.baruch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).