From: Maximilian Luz <luzmaximilian@gmail.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Jonas Dreßler" <verdre@v0yd.nl>,
"Amitkumar Karwar" <amitkarwar@gmail.com>,
"Xinming Hu" <huxinming820@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Tsuchiya Yuto" <kitakar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 2/2] mwifiex: pcie: add reset_d3cold quirk for Surface gen4+ devices
Date: Sat, 10 Jul 2021 00:25:36 +0200 [thread overview]
Message-ID: <bfbb3b4d-07f7-1b97-54f0-21eba4766798@gmail.com> (raw)
In-Reply-To: <20210709212505.mmqxdplmxbemqzlo@pali>
On 7/9/21 11:25 PM, Pali Rohár wrote:
[...]
> PCIe Function Level Reset should reset only one PCIe part of device. And
> seems that this type of reset does not work properly in some situations.
>
> Note that PCIe Function Level Reset is independent of running firmware.
> It is implement in hardware and (should) work also at early stage when
> firmware is not loaded yet.
>
> I'm starting to think more and more if quirk in this patch really needs
> to be behind DMI check and if rather it should not be called on other
> platforms too?
Maybe? I'm not sure how well this behaves on other devices and if there
even are any devices outside of the MS Surface line that really require
or benefit from something like this. To me it seems safer to put it
behind quirks, at least until we know more.
Also not sure if this is just my bias, but it feels like the Surface
line always had more problems with that driver (and firmware) than
others. I'm honestly a bit surprised that MS stuck with them for this
long (they decided to go with Intel for 7th gen devices). AFAICT they
initially chose Marvell due to connected standby support, so maybe that
causes issue for us and others simply aren't using that feature? Just
guessing though.
next prev parent reply other threads:[~2021-07-09 22:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 14:58 [PATCH v2 0/2] mwifiex: Add quirks for MS Surface devices Jonas Dreßler
2021-07-09 14:58 ` [PATCH v2 1/2] mwifiex: pcie: add DMI-based quirk implementation for " Jonas Dreßler
2021-07-31 8:50 ` Kalle Valo
2021-07-09 14:58 ` [PATCH v2 2/2] mwifiex: pcie: add reset_d3cold quirk for Surface gen4+ devices Jonas Dreßler
2021-07-09 15:18 ` Pali Rohár
2021-07-09 15:33 ` Jonas Dreßler
2021-07-09 16:12 ` Pali Rohár
2021-07-09 17:03 ` Maximilian Luz
2021-07-09 17:30 ` Pali Rohár
2021-07-09 18:16 ` Maximilian Luz
2021-07-09 18:44 ` Pali Rohár
2021-07-09 19:27 ` Maximilian Luz
2021-07-09 19:44 ` Pali Rohár
2021-07-09 20:54 ` Maximilian Luz
2021-07-09 21:25 ` Pali Rohár
2021-07-09 22:25 ` Maximilian Luz [this message]
2021-07-09 22:54 ` Pali Rohár
2021-07-10 0:00 ` Maximilian Luz
2021-07-10 0:07 ` Pali Rohár
2021-07-10 0:18 ` Maximilian Luz
2021-07-10 0:38 ` Pali Rohár
2021-07-10 1:07 ` Maximilian Luz
2021-07-11 16:53 ` Jonas Dreßler
2021-07-11 17:01 ` Pali Rohár
2021-07-11 16:31 ` Jonas Dreßler
2021-07-09 16:01 ` Andy Shevchenko
2021-07-09 16:31 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfbb3b4d-07f7-1b97-54f0-21eba4766798@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).