From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>, Xie Qirong <cheerx1994@gmail.com>
Cc: Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer
Date: Fri, 12 May 2017 10:36:56 +0200 [thread overview]
Message-ID: <c5e21126-23e6-8cef-d01b-dc225dab1982@broadcom.com> (raw)
In-Reply-To: <87tw4qqyh1.fsf@kamboji.qca.qualcomm.com>
On 5/12/2017 10:19 AM, Kalle Valo wrote:
> Xie Qirong <cheerx1994@gmail.com> writes:
>
>> The combination of init_timer and setting up the data and function field
>> manually is equivalent to calling setup_timer(). This is an api
>> consolidation only and improves readability.
>>
>> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> Signed-off-by: Xie Qirong <cheerx1994@gmail.com>
>> ---
>>
>> setup_timer.cocci suggested the following improvement:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use
>> setup_timer function for function on line 384.
>>
>> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y +
>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y +
>> CONFIG_BRCMDBG=y
>>
>> Kernel version: 4.11.0 (localversion-next is next-20170512)
>
> How is this different from the first version?
>
> https://patchwork.kernel.org/patch/9709467/
Hi Kalle,
This is actually the third version. You are referring to the
not-specifically-named "v2" here, but how are you to know ;-) This third
version is the same as v1 on which I commented to put the coccinelle
output in the commit message. So I would still keep v2 if nothing else
changed in v3 apart from my Acked-by: tag.
Regards,
Arend
> Always add patch version "[PATCH v2]" and a changelog. I added a section
> "Frequent problems" to the wiki to mention about these common problems:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
>
next prev parent reply other threads:[~2017-05-12 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 7:35 [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer Xie Qirong
2017-05-12 8:19 ` Kalle Valo
2017-05-12 8:36 ` Arend van Spriel [this message]
2017-05-12 8:54 ` Kalle Valo
2017-05-12 9:10 ` Arend van Spriel
2017-05-12 9:16 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-05-03 11:27 Xie Qirong
2017-05-03 7:35 Xie Qirong
2017-05-03 8:05 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5e21126-23e6-8cef-d01b-dc225dab1982@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=cheerx1994@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).