From: Rakesh Pillai <pillair@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Surabhi Vishnoi <svishnoi@codeaurora.org>
Subject: Re: [PATCH] ath10k: Fill the channel survey results for WCN3990 correctly
Date: Wed, 17 Oct 2018 16:51:44 +0530 [thread overview]
Message-ID: <c825412eeccfee7a3ca6ebe0b9e68ea8@codeaurora.org> (raw)
In-Reply-To: <87murj2mc0.fsf@kamboji.qca.qualcomm.com>
Hi Kalle,
I have removed the clk_freq variable and now there will be u32 division
only.
This change has been sent in v2.
Thanks,
Rakesh Pillai.
On 2018-10-12 21:23, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Rakesh Pillai <pillair@codeaurora.org> wrote:
>>
>>> The host driver currently expects the channel info event to be
>>> received in pairs for all the channels, i.e. the first
>>> chan_info event for a particular channel will not have the
>>> COMPLETE flag set and the second chan_info event for the
>>> same channel will have the COMPLETE flag set.
>>>
>>> The HL2.0 firmware sends only one channel info event per channel
>>> which is scanned without the COMPLETE flag set. After sending the
>>> chan_info_event for all the channels, the HL2.0 firmware sends a
>>> chan_info_event with COMPLETE flag set to indicate the completion
>>> of the channel info event.
>>>
>>> The firmware does not indicate this behavior with any service bitmap
>>> and hence a new firmware feature flag is used to handle the modified
>>> parsing of the channel info events, in the host driver, for the
>>> firmware which sends single channel info event per scanned channel.
>>>
>>> Tested HW: WCN3990
>>> Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
>>>
>>> Co-developed-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>>> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>> Kbuild bot reported some errors:
>>
>>>> ERROR: "__udivdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko]
>>>> undefined!
>>>> ERROR: "__divdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko]
>>>> undefined!
>>
>> Need to investigate those if they are valid or problem with the bot.
>
> Arnd explained the problem in the other thread:
>
> "I think the problem is that 'clock_freq' is a 'u64', which means we
> can't use a normal 32-bit division. It looks like it cannot actually
> go beyond the range of a u32, so changing the type should be
> sufficient."
>
> Please investigate that and submit v2.
prev parent reply other threads:[~2018-10-17 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 10:57 [PATCH] ath10k: Fill the channel survey results for WCN3990 correctly Rakesh Pillai
2018-10-12 14:34 ` Kalle Valo
[not found] ` <20181012143434.3F49060A98@smtp.codeaurora.org>
2018-10-12 15:53 ` Kalle Valo
2018-10-17 11:21 ` Rakesh Pillai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c825412eeccfee7a3ca6ebe0b9e68ea8@codeaurora.org \
--to=pillair@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=svishnoi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).