linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stam, Michel [FINT]" <m.stam@fugro.com>
To: Antonio Quartulli <a@unstable.cc>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Antonio Quartulli" <antonio@open-mesh.com>
Subject: RE: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption
Date: Mon, 9 Jan 2017 08:57:31 +0000	[thread overview]
Message-ID: <c8cf3cb978484560befe95900095eff1@nldataex02.ad.fugro.com> (raw)
In-Reply-To: <20161022134222.GQ12558@prodigo.lan>

Hello Antonio,

Actually, I fixed the usage of mac80211 internals in one of my patches by iterating through the mac80211 cache entries (there's a function for that). This did have some locking issues afaik, but it made the key cache corruption occur less frequently.

So it may solve a key cache corruption problem, but it does not completely solve the particular problem that we are experiencing. Hence, I cannot say whether this patch would do anything useful (no test situation here). Since it is not a complete solution, it may warrant further looking into.

Please also take a look here:
https://github.com/cozybit/authsae/issues/42


Kind regards,

Michel Stam

-----Original Message-----
From: ath9k-devel-bounces@lists.ath9k.org [mailto:ath9k-devel-bounces@lists.ath9k.org] On Behalf Of Antonio Quartulli
Sent: Saturday, October 22, 2016 15:42 PM
To: ath9k-devel@lists.ath9k.org
Cc: linux-wireless@vger.kernel.org; Antonio Quartulli
Subject: Re: [ath9k-devel] [NOT FOR MERGE] ath9k: work around key cache corruption

Hello,

I am trying to understand what's required by this patch to be merged upstream.
Sven Eckelmann commented in another email by saying:

"The patch itself has (at least) one big problem. It is using some mac80211
internals in ath_key_config_iter to make sure that the uploaded keys were
actually programmed in the hardware. Without this check the keys could end up
in the lower slots and thus break all connections."


Does anybody else have any other additional comment?
(Please keep me in CC as I am not registered to the ath9k ML).

Cheers,

On Tue, Oct 18, 2016 at 04:35:52PM +0800, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
> 
> This patch was crafted long time ago to work around a key cache
> corruption problem on ath9k chipsets.
> 
> The workaround consists in periodically triggering a worker that
> uploads all the keys to the HW cache. The worker is triggered also
> when the vif detects 21 undecryptable packets.
> 
> 
> This patch is based on top compat-wireless-2015-10-26.
> 
> 
> I was asked to release this code to the public and, since it is
> GPL, I am now doing it.
> 
> 
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>

-- 
Antonio Quartulli

  parent reply	other threads:[~2017-01-09  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18  8:35 [NOT FOR MERGE] ath9k: work around key cache corruption Antonio Quartulli
2016-10-22 13:42 ` Antonio Quartulli
2016-10-22 20:34   ` Johannes Berg
2017-01-09  8:57   ` Stam, Michel [FINT] [this message]
2016-10-26 14:05 ` Kalle Valo
2016-10-26 14:10   ` Antonio Quartulli
2016-10-27  6:02     ` Kalle Valo
2016-10-27  7:54       ` Sebastian Gottschall
2016-10-27 15:06         ` Johannes Berg
2016-11-14 12:50           ` [ath9k-devel] " Stam, Michel [FINT]
2016-11-14 23:25             ` Adrian Chadd
2016-11-16  8:54               ` Stam, Michel [FINT]
2016-10-26 14:43   ` Ferry Huberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8cf3cb978484560befe95900095eff1@nldataex02.ad.fugro.com \
    --to=m.stam@fugro.com \
    --cc=a@unstable.cc \
    --cc=antonio@open-mesh.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).