From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: ath10k <ath10k@lists.infradead.org>,
wireless <linux-wireless@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>,
Jami Kettunen <jamipkettunen@gmail.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop
Date: Thu, 28 Mar 2024 18:09:47 +0100 [thread overview]
Message-ID: <c908125e-84fb-42f3-bbb5-3d4a909038d8@freebox.fr> (raw)
In-Reply-To: <4b7bf7cc-ede6-4c2a-983c-da4c8c09c5d1@quicinc.com>
On 26/03/2024 21:21, Jeff Johnson wrote:
> On 3/26/2024 10:51 AM, Dmitry Baryshkov wrote:
>
>> On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote:
>>>
>>> [ It has been pointed out to me that the previous message was unclear. ]
>>> [ Below is my 2nd attempt at a clearer message. ]
>>>
>>> Problem: firmware-5.bin has not been parsed yet when we have to handle
>>> the ATH10K_QMI_EVENT_SERVER_ARRIVE case, so we can't rely on feature bits
>>> to work around the lack of MSA_READY indicator.
>>
>> Then, I'd say, we have to resort to the DT property, unless Kalle or
>> Jeff have other proposals.
>
> Another option is to follow the downstream driver model and only expect this
> based upon static configuration within the driver.
>
> Downstream driver has:
> if (priv->device_id == ADRASTEA_DEVICE_ID) {
> ret = wlfw_msa_mem_info_send_sync_msg(priv);
> ret = wlfw_msa_ready_send_sync_msg(priv);
> }
>
> https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/platform/-/blob/wlan-platform.lnx.1.0.r4-rel/icnss2/main.c?ref_type=heads#L968
>
> The downstream MSA logic (including some other code that populates MSA-related
> fields in the QMI messages) is only invoked for ADRASTEA_DEVICE_ID.
>
> We could introduce a new hw_params parameter to have the same semantics.
>
> But I'm OK with the DT option as well.
>
> Kalle?
I'll send a v2 series with the DT option + setting the quirk flag for
all msm8998 devices. I'll include msm8998 board maintainers for feedback.
Regards
next prev parent reply other threads:[~2024-03-28 17:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 13:22 [PATCH 0/2] Work around missing MSA_READY indicator from ath10k FW Marc Gonzalez
2024-02-28 13:24 ` [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Marc Gonzalez
2024-02-28 14:03 ` Kalle Valo
2024-02-28 16:12 ` Marc Gonzalez
2024-02-28 16:37 ` Kalle Valo
2024-02-28 17:19 ` Marc Gonzalez
2024-03-01 8:10 ` Kalle Valo
2024-03-04 15:51 ` Marc Gonzalez
2024-03-05 14:31 ` Kalle Valo
2024-03-05 17:32 ` Marc Gonzalez
2024-03-05 19:20 ` Kalle Valo
2024-03-13 15:09 ` Marc Gonzalez
2024-03-13 15:48 ` Konrad Dybcio
2024-03-13 15:53 ` Dmitry Baryshkov
2024-03-14 12:31 ` Marc Gonzalez
2024-03-14 12:52 ` Dmitry Baryshkov
2024-03-18 16:56 ` Marc Gonzalez
2024-03-19 13:47 ` Marc Gonzalez
2024-03-19 14:39 ` Marc Gonzalez
2024-03-19 17:05 ` Marc Gonzalez
2024-03-26 15:04 ` Marc Gonzalez
2024-03-26 17:45 ` Marc Gonzalez
2024-03-26 17:51 ` Dmitry Baryshkov
2024-03-26 20:21 ` Jeff Johnson
2024-03-28 17:09 ` Marc Gonzalez [this message]
2024-02-29 18:40 ` Conor Dooley
2024-02-29 19:46 ` Jeff Johnson
2024-03-07 15:29 ` Marc Gonzalez
2024-03-07 16:46 ` Jeff Johnson
2024-03-14 14:33 ` Jeff Johnson
2024-03-14 17:52 ` Marc Gonzalez
2024-03-14 19:28 ` Jeff Johnson
2024-03-04 16:21 ` Marc Gonzalez
2024-03-04 19:34 ` Conor Dooley
2024-03-04 19:37 ` Dmitry Baryshkov
2024-03-04 19:45 ` Conor Dooley
2024-03-04 19:59 ` Dmitry Baryshkov
2024-03-04 20:17 ` Conor Dooley
2024-03-04 20:21 ` Dmitry Baryshkov
2024-03-05 8:04 ` Krzysztof Kozlowski
2024-03-05 13:41 ` Marc Gonzalez
2024-03-05 15:02 ` Kalle Valo
2024-03-05 14:45 ` Kalle Valo
2024-02-28 14:59 ` Jeff Johnson
2024-02-28 16:00 ` Marc Gonzalez
2024-02-29 15:49 ` Marc Gonzalez
2024-02-28 13:25 ` [PATCH 2/2] wifi: ath10k: work around missing MSA_READY indicator Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c908125e-84fb-42f3-bbb5-3d4a909038d8@freebox.fr \
--to=mgonzalez@freebox.fr \
--cc=andersson@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=avrac@freebox.fr \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jamipkettunen@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).