Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: Aloka Dixit <alokad@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v4 1/2] nl80211: Add FILS discovery support
Date: Thu, 30 Jul 2020 14:53:40 -0700
Message-ID: <ca081672e9e3407bec949c963add8530@codeaurora.org> (raw)
In-Reply-To: <54628f052b380e660c37cb9b7c3f224976aa1c83.camel@sipsolutions.net>

On 2020-07-30 14:22, Johannes Berg wrote:
> On Thu, 2020-07-30 at 14:17 -0700, Aloka Dixit wrote:
> 
>> > OTOH, if it's with headers, how could it be optional? In fact, either
>> > way, how is it optional?
>> >
>> 
>> Template has management frame headers as well. Will change the wording
>> accordingly.
> 
> OK.
> 
>> I made the template optional because FILS discovery may or may not be
>> offloaded to FW.
> 
> But how would anyone know? Try without it, and then try again if that
> fails? Would it fail? I mean, you also said it was required at least 
> for
> 6 GHz, so wouldn't userspace be better off always giving it - and then
> we should probably make it mandatory so it doesn't fall into the trap?
> 

If the template is not provided, FW keeps sending event to get it.
But as my ath11k driver code is limited to 6GHz, it already throws error 
if template not provided.
Yes, in general it will be better to make it mandatory, I will do it in 
next version.

> However - and here that's my ignorance speaking - can it really be
> offloaded? I mean, is everything in there completely determined by the
> beacon already, and so you have no choice in how to build it? Or how
> does that work?
> 

Yes, the frame parameters are fixed except for the timestamp which FW is 
expected to fill.

>> Yeah, I looked through existing examples for NLA_BINARY, those provide
>> only the higher bound for length.
> 
> Yeah, no way to do anything else right now. But you should have a lower
> bound in the code, I think.
> 

Okay.

>> But I can modify it to range once that is added.
> 
> Later maybe :)
> 
> johannes

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  5:04 [PATCH v4 0/2] " Aloka Dixit
2020-06-18  5:04 ` [PATCH v4 1/2] nl80211: " Aloka Dixit
2020-07-30 14:43   ` Johannes Berg
2020-07-30 21:17     ` Aloka Dixit
2020-07-30 21:22       ` Johannes Berg
2020-07-30 21:53         ` Aloka Dixit [this message]
2020-06-18  5:04 ` [PATCH v4 2/2] mac80211: " Aloka Dixit
2020-07-30 14:47   ` Johannes Berg
2020-07-30 21:00     ` Aloka Dixit
2020-07-30 21:26       ` Johannes Berg
2020-07-30 22:08         ` Aloka Dixit
2020-07-31  8:21           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca081672e9e3407bec949c963add8530@codeaurora.org \
    --to=alokad@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git