linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Federico Cuello <fedux@fedux.com.ar>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Brian Norris <briannorris@chromium.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Wen Gong <wgong@codeaurora.org>,
	Miaoqing Pan <miaoqing@codeaurora.org>
Subject: Re: ath10k: Poor performance with kernel 5.3 fixed
Date: Fri, 27 Sep 2019 11:25:51 +0200	[thread overview]
Message-ID: <d046019cbb4a5b3a16357d8d1209ebf5@fedux.com.ar> (raw)
In-Reply-To: <87k19vi5fw.fsf@tynnyri.adurom.net>

On 2019-09-26 14:54, Kalle Valo wrote:
> + Miaoqing
> 
> Federico Cuello <fedux@fedux.com.ar> writes:
> 
>> On 2019-09-25 18:24, Brian Norris wrote:
>>> On Wed, Sep 25, 2019 at 2:16 AM Federico Cuello <fedux@fedux.com.ar>
>>> wrote:
>>>> When upgrading to 5.3 my AP started to work really slow. I tracked
>>>> the problem to 4504f0e5b5714d9d26b1a80bf1fc133c95830588 and fixed
>>>> the issue.
>>> 
>>> For the record, that's:
>>> 4504f0e5b571 ath10k: sdio: workaround firmware UART pin
>>> configuration bug
>> 
>> 
>>> 
>>>> The attached patch fixes the issue when uart_print is false and
>>>> uart_pin_workaround also false.
>>> 
>>> -ENOPATCH
>> 
>> Sorry, I sent it in a different email "attached to the thread", but in
>> any case, there was the same fix already applied to kvalo's tree.
>> 
>> Here is the patch and link to already applied fix:
>> 
>>   https://patchwork.kernel.org/patch/11160267/
>> 
>> 
>> It would be great if we can get this to stable, in my case, my WiFi
>> speed went from 150 Mbit/s to 1-5 Mbit/s without this fix.
> 
> I didn't know that the bug was severe and I applied the patch to
> ath-next, which means it will go to v5.5 which is bad. (This is why I
> always ask people to clearly describe the bug in the commit log!)
> 
> In theory I could also push it to v5.4 but I just don't want to deal
> with the possible conflicts coming from duplicate commits.

I don't know how this is affecting others. Miaoqing? How did this affect 
you?

Also, would it be possible maybe to revert the patch and re-apply it 
with stable CCed to avoid any possible conflicts and get it to stable? I 
can still just patch my kernels if this is not big deal for others.

      reply	other threads:[~2019-09-27  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25  9:08 ath10k: Poor performance with kernel 5.3 fixed Federico Cuello
2019-09-25  9:08 ` [PATCH] ath10k: Fix ath10k_init_uart when uart_print is false Federico Cuello
2019-09-25 12:02   ` Kalle Valo
2019-09-25 16:24 ` ath10k: Poor performance with kernel 5.3 fixed Brian Norris
2019-09-26  7:56   ` Federico Cuello
2019-09-26 12:54     ` Kalle Valo
2019-09-27  9:25       ` Federico Cuello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d046019cbb4a5b3a16357d8d1209ebf5@fedux.com.ar \
    --to=fedux@fedux.com.ar \
    --cc=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miaoqing@codeaurora.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).