linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] wifi: cfg80211: add support for link id attribute in NL80211_CMD_DEL_STATION
Date: Tue, 30 Jan 2024 19:19:17 +0530	[thread overview]
Message-ID: <d04c6d82-b667-451d-a52f-ccf715a13d32@quicinc.com> (raw)
In-Reply-To: <c67b618f9e40c2629c3eef825788dcf07da76479.camel@sipsolutions.net>

On 1/30/24 17:24, Johannes Berg wrote:
> On Tue, 2024-01-30 at 16:41 +0530, Aditya Kumar Singh wrote:
> 
>> Yeah :). Even I haven't seen kernel not removing the entries while the
>> interface was going down. Was just thinking out loud here. Tbh, even I
>> don't know the exact reason it was written in that way. Was guessing.
> 
> It's probably just old ... :)
> 
>>> Note this raises an interesting point in mac80211, in that there's one
>>> link ('deflink', the link the STA used to assoc) that cannot be removed
>>> from an MLD station even.
>>>
>>
>> Good point :) I did not think about this. Let me think again how to
>> handle this case. Thanks.
> 
> You don't actually have to now though - you're _not_ removing just
> links, you're removing the whole station with all links, as long as it
> has a link with the relevant link ID.
> 

Yeah that is true. Not for this change. But the other one I'm working on 
is the link removal area. So there I need to be care full.


  reply	other threads:[~2024-01-30 13:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 12:58 [PATCH 0/3] wifi: cfg80211/mac80211: add support to flush stations based on link ID Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH 1/3] wifi: cfg80211: add support for link id attribute in NL80211_CMD_DEL_STATION Aditya Kumar Singh
2024-01-26  9:06   ` Johannes Berg
2024-01-27  5:44     ` Aditya Kumar Singh
2024-01-30 10:46       ` Johannes Berg
2024-01-30 11:11         ` Aditya Kumar Singh
2024-01-30 11:54           ` Johannes Berg
2024-01-30 13:49             ` Aditya Kumar Singh [this message]
2024-01-25 12:58 ` [PATCH 2/3] wifi: mac80211: add link id argument for sta_flush() function Aditya Kumar Singh
2024-01-26  9:11   ` Johannes Berg
2024-01-27  5:46     ` Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH 3/3] wifi: mac80211: remove only own link stations during stop_ap Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH v5 0/3] wifi: cfg80211/mac80211: add link_id handling in AP channel switch during Multi-Link Operation Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH v5 1/3] wifi: cfg80211: send link id in channel_switch ops Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH v5 2/3] wifi: mac80211: add support for AP channel switch with MLO Aditya Kumar Singh
2024-01-25 12:58 ` [PATCH v5 3/3] wifi: mac80211: update beacon counters per link basis Aditya Kumar Singh
2024-01-25 13:02 ` [PATCH 0/3] wifi: cfg80211/mac80211: add support to flush stations based on link ID Aditya Kumar Singh
  -- strict thread matches above, loose matches on Subject: below --
2024-01-24 13:28 Aditya Kumar Singh
2024-01-24 13:28 ` [PATCH 1/3] wifi: cfg80211: add support for link id attribute in NL80211_CMD_DEL_STATION Aditya Kumar Singh
2024-01-24 23:40   ` Jeff Johnson
2024-01-25  3:32     ` Aditya Kumar Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d04c6d82-b667-451d-a52f-ccf715a13d32@quicinc.com \
    --to=quic_adisi@quicinc.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).