From: Larry Finger <Larry.Finger@lwfinger.net>
To: Sven Joachim <svenjoac@gmx.de>
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] rtlwifi: Fix fallback firmware loading
Date: Sun, 30 Jul 2017 18:57:57 -0500 [thread overview]
Message-ID: <d1c1790d-015d-4dae-8532-42701737eea3@lwfinger.net> (raw)
In-Reply-To: <87a83noaxw.fsf@turtle.gmx.de>
On 07/29/2017 04:21 AM, Sven Joachim wrote:
> Commit f70e4df2 ("rtlwifi: Add code to read new versions of firmware")
> added code to load an old firmware file if the new one is not
> available. Unfortunately that code is never reached because
> request_firmware_nowait() does not wait for the firmware to show up
> and returns 0 even if the file is not there.
>
> Use the existing fallback mechanism introduced by commit
> 62009b7f ("rtlwifi: rtl8192cu: Add new firmware") instead.
>
> Fixes: f70e4df2b384d21e36a7c30a591639592692e0ec
> Cc: stable@vger.kernel.org
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
Your solution seems to be correct; however, your patch fails to apply. Make
certain that you have the latest pull on the wireless-drivers-next repo. In
particular, it needs commit f2764f61fa105 by Souptik Jarder, which changed the
error return.
NACK.
Larry
next prev parent reply other threads:[~2017-07-30 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 11:14 Loading fallback firmware in rtl8723be and rtl8821ae fails Sven Joachim
2017-07-29 9:21 ` [PATCH] rtlwifi: Fix fallback firmware loading Sven Joachim
2017-07-30 23:57 ` Larry Finger [this message]
2017-07-31 16:10 ` [PATCH v2] " Sven Joachim
2017-08-03 9:36 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c1790d-015d-4dae-8532-42701737eea3@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).