From: Alexander Lobakin <alobakin@dlink.ru>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: Luciano Coelho <luciano.coelho@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Edward Cree <ecree@solarflare.com>,
Jiri Pirko <jiri@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
Ido Schimmel <idosch@mellanox.com>,
Paolo Abeni <pabeni@redhat.com>,
Petr Machata <petrm@mellanox.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"Kenneth R. Crudup" <kenny@panix.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: wireless: intel: iwlwifi: fix GRO_NORMAL packet stalling
Date: Wed, 27 Nov 2019 14:44:54 +0300 [thread overview]
Message-ID: <d2c0caa0b14c6fddbf8155b4edbd7fcd@dlink.ru> (raw)
In-Reply-To: <PSXP216MB04382F0BA8CE3754439EA2CC80440@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Nicholas Johnson wrote 27.11.2019 14:16:
> On Wed, Nov 27, 2019 at 01:29:03PM +0300, Alexander Lobakin wrote:
>> Nicholas Johnson wrote 27.11.2019 13:23:
>> > Hi,
>>
>> Hi Nicholas,
>>
>> > Sorry for top down reply, stuck with my phone. If it replies HTML
>> > then I am so done with Outlook client.
>
> I am very sorry to everybody for the improper reply. It looks like it
> was HTML as vger.kernel.org told me I was spam. If anybody knows a good
> email client for kernel development for Android then I am all ears.
>
> I went home early and I have my computer(s) now.
>
>> >
>> > Does my Reported-by tag apply here?
>> >
>> > As the reporter, should I check to see that it indeed solves the
>> > issue on the original hardware setup? I can do this within two hours
>> > and give Tested-by then.
>>
>> Oops, I'm sorry I forgot to mention you in the commit message. Let's
>> see what Dave will say, I have no problems with waiting for your test
>> results and publishing v2.
>
> All good. :)
>
> I tested the the patch and it works fine. Great work, the first
> hypothesis as to what the problem was is correct. It now connects to
> wireless networks without any hassles.
>
> Reported-by: Nicholas Johnson
> <nicholas.johnson-opensource@outlook.com.au>
> Tested-by: Nicholas Johnson
> <nicholas.johnson-opensource@outlook.com.au>
Oh, much thanks for testing this out! I think this one will hit netdev
fixes tree soon.
> I do not understand the networking subsystem well enough to give
> Reviewed-by, yet. Hopefully in time.
I'm sure you will :)
> Thanks to everybody for handling my report.
>
>>
>> > Thanks
>> >
>> > Regards,
>> >
>> > Nicholas
>>
>> Regards,
>> ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
>
> Regards,
> Nicholas
Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
next prev parent reply other threads:[~2019-11-27 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:41 [PATCH net] net: wireless: intel: iwlwifi: fix GRO_NORMAL packet stalling Alexander Lobakin
2019-11-27 9:58 ` Luciano Coelho
2019-11-27 10:12 ` Alexander Lobakin
[not found] ` <PSXP216MB0438B2F163C635F8B8B4AD8AA4440@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
2019-11-27 10:29 ` Alexander Lobakin
2019-11-27 11:16 ` Nicholas Johnson
2019-11-27 11:44 ` Alexander Lobakin [this message]
2019-11-27 13:38 ` Kalle Valo
2019-11-27 16:05 ` Edward Cree
2019-11-27 16:31 ` Alexander Lobakin
2019-11-27 19:23 ` David Miller
2019-11-27 19:28 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c0caa0b14c6fddbf8155b4edbd7fcd@dlink.ru \
--to=alobakin@dlink.ru \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=kenny@panix.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).