From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA60EC432C0 for ; Tue, 3 Dec 2019 09:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7F3C207DD for ; Tue, 3 Dec 2019 09:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbfLCJKi (ORCPT ); Tue, 3 Dec 2019 04:10:38 -0500 Received: from mga09.intel.com ([134.134.136.24]:34620 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfLCJKi (ORCPT ); Tue, 3 Dec 2019 04:10:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 01:10:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,272,1571727600"; d="scan'208";a="200932962" Received: from cmccall-mobl1.ger.corp.intel.com ([10.252.22.53]) by orsmga007.jf.intel.com with ESMTP; 03 Dec 2019 01:10:36 -0800 Message-ID: Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" From: Luciano Coelho To: Kalle Valo Cc: Anders Kaseorg , Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , linux-wireless@vger.kernel.org Date: Tue, 03 Dec 2019 11:10:35 +0200 In-Reply-To: <0101016ecb05064e-722ee289-5d94-4275-a1f9-24dd0cfaeef7-000000@us-west-2.amazonses.com> References: <0101016ecab326d1-88123857-cf37-47ab-b452-13658625364c-000000@us-west-2.amazonses.com> <7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com> <0101016ecb05064e-722ee289-5d94-4275-a1f9-24dd0cfaeef7-000000@us-west-2.amazonses.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2+b1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-12-03 at 09:08 +0000, Kalle Valo wrote: > Luciano Coelho writes: > > > On Tue, 2019-12-03 at 07:39 +0000, Kalle Valo wrote: > > > Anders Kaseorg writes: > > > > > > > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99. > > > > > > > > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4 > > > > attempted to fix the same bug (dead assignments to the local variable > > > > cfg), but they did so in incompatible ways. When they were both merged, > > > > independently of each other, the combination actually caused the bug to > > > > reappear, leading to a firmware crash on boot for some cards. > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=205719 > > > > > > > > Signed-off-by: Anders Kaseorg > > > > --- > > > > [Nope it was more than just format=flowed damage. This one should be > > > > better for real.] > > > > > > This is nitpicking but as a general comment I would prefer to use simple > > > version numbering v2, v3 and so on. Trying to sort v1.2 in a script is > > > awful. So calling this version v3 is very much preferred, it's not like > > > we are running out of numbers :) > > > > Kalle, this patch makes sense. There was some merge damage because the > > functions were moved around and the local variables' names have > > changed, causing this mess. > > > > Can you please take this patch to v5.4 fixes when you're satisfied? > > Ok, I assigned this to myself and queue for v5.5. Thanks! And yeah, I meant v5.5, obviously. It should reach v5.4 as part of stable. -- Cheers, Luca.