From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C07DC31E54 for ; Mon, 17 Jun 2019 08:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D3B02080A for ; Mon, 17 Jun 2019 08:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfFQIri (ORCPT ); Mon, 17 Jun 2019 04:47:38 -0400 Received: from mga09.intel.com ([134.134.136.24]:10238 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfFQIrh (ORCPT ); Mon, 17 Jun 2019 04:47:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 01:47:37 -0700 X-ExtLoop1: 1 Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by fmsmga008.fm.intel.com with ESMTP; 17 Jun 2019 01:47:32 -0700 Subject: Re: [PATCH v4 4/5] mmc: core: Add sdio_retune_hold_now() and sdio_retune_release() To: Doug Anderson , Ulf Hansson , Arend van Spriel Cc: Kalle Valo , brcm80211-dev-list.pdl@broadcom.com, "open list:ARM/Rockchip SoC..." , Double Lo , Brian Norris , linux-wireless , Naveen Gupta , Madhan Mohan R , Matthias Kaehlcke , Wright Feng , Chi-Hsien Lin , netdev , brcm80211-dev-list , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Thomas Gleixner , Greg Kroah-Hartman , Avri Altman References: <20190613234153.59309-1-dianders@chromium.org> <20190613234153.59309-5-dianders@chromium.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 17 Jun 2019 11:46:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 14/06/19 7:38 PM, Doug Anderson wrote: > Hi, > > On Fri, Jun 14, 2019 at 5:10 AM Ulf Hansson wrote: >> >> On Fri, 14 Jun 2019 at 01:42, Douglas Anderson wrote: >>> >>> We want SDIO drivers to be able to temporarily stop retuning when the >>> driver knows that the SDIO card is not in a state where retuning will >>> work (maybe because the card is asleep). We'll move the relevant >>> functions to a place where drivers can call them. >>> >>> Signed-off-by: Douglas Anderson >> >> This looks good to me. >> >> BTW, seems like this series is best funneled via my mmc tree, no? In >> such case, I need acks for the brcmfmac driver patches. > > For patch #1 I think it could just go in directly to the wireless > tree. It should be fine to land the rest of the patches separately. > > For patch #2 - #5 then what you say makes sense to me. I suppose > you'd want at least a Reviewed-by from Arend and an Ack from Kalle on > the Broadcom patches? > > I'd also suggest that we Cc stable explicitly when applying. That's > easy for #2 and #3 since they have a Fixes tag. For #4 and #5 I guess > the question is how far back to go. Maybe Adrian has an opinion here > since I think he's the one who experienced these problems. V4 seemed to apply cleanly back to v4.18