From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4C7C4320A for ; Mon, 9 Aug 2021 20:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C59F61004 for ; Mon, 9 Aug 2021 20:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235419AbhHIUBK (ORCPT ); Mon, 9 Aug 2021 16:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235812AbhHIUBH (ORCPT ); Mon, 9 Aug 2021 16:01:07 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 157FFC061798; Mon, 9 Aug 2021 13:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=Om3EEuXdHWjYj9gS/+HAJ1lLyTQFKGdm9B9GiLl+f8Y=; t=1628539246; x=1629748846; b=DaCNr5SrePeGkwD19tm3CVKB3cEUTAUuL1sDroRaaSmLFFY S+alGsOVFMBS1TtyTKqNAQIz9jaKCo9kc965iX8EMgNfhWq7Yl/Bq0t6Re2VT9tEQkTD4U9JGUr1I ucglAaL0JP/CDmBoFsc+QtMwogYxO+X/xepDddxrWh+XtC7F7N5YA/zz+Sz8rL26i09+xyVyDYDx2 VqOJgs7nj9Y70RwmFavLngn1QnTQCbjHZ7pjcoAZtYSG8oZvn8bB8bHqCNn6hTg39NycIsAFye/Hr 5tNfJ74MCfgamAe4g0O7k3obTG87lm+H9DWXqGGXDUz9OwM8KRH/3FTxUNXFtpkQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1mDBPI-008GAP-OL; Mon, 09 Aug 2021 22:00:35 +0200 Message-ID: Subject: Re: [PATCH RFC v1 3/7] rtw88: Use rtw_iterate_stas where the iterator reads or writes registers From: Johannes Berg To: Pkshih , Martin Blumenstingl Cc: "linux-wireless@vger.kernel.org" , "tony0620emma@gmail.com" , "kvalo@codeaurora.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Neo Jou , Jernej Skrabec Date: Mon, 09 Aug 2021 22:00:34 +0200 In-Reply-To: <981001e2981346ada4dcc08558b87a18@realtek.com> References: <20210717204057.67495-1-martin.blumenstingl@googlemail.com> <20210717204057.67495-4-martin.blumenstingl@googlemail.com> <27d8246ef3c9755b3e6e908188ca36f7b0fab3fc.camel@sipsolutions.net> <981001e2981346ada4dcc08558b87a18@realtek.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > > I am thinking rtw88 needs to maintain sta and vif lists itself,  I would tend to prefer drivers do not maintain separate lists - that's just duplicated book-keeping and prone to state mismatch errors? But OTOH the locking does make things complex. johannes