From: Felix Fietkau <nbd@nbd.name>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: mt76: mt7915: add two additional errors to ack-failure mask.
Date: Sat, 1 Oct 2022 13:44:35 +0200 [thread overview]
Message-ID: <d67b5450-1f2b-63c1-8056-44fbe9737128@nbd.name> (raw)
In-Reply-To: <20220929151526.9559-2-greearb@candelatech.com>
On 29.09.22 17:15, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> These other two bits also indicate tx failure as far as I can tell from
> reading the documents.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
The bits seem to have overlapping meaning, not sure if they always
reliably indicate an error. I think we should leave this patch out, as
it could potentially cause regressions.
- Felix
prev parent reply other threads:[~2022-10-01 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 15:15 [PATCH 1/2] wifi: mt76: mt7915: fix bounds checking for tx-free-done command greearb
2022-09-29 15:15 ` [PATCH 2/2] wifi: mt76: mt7915: add two additional errors to ack-failure mask greearb
2022-10-01 11:44 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67b5450-1f2b-63c1-8056-44fbe9737128@nbd.name \
--to=nbd@nbd.name \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).