Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: <Ajay.Kathat@microchip.com>
To: <lkp@intel.com>, <linux-wireless@vger.kernel.org>
Cc: <kbuild-all@lists.01.org>, <devel@driverdev.osuosl.org>,
	<Venkateswara.Kaja@microchip.com>, <gregkh@linuxfoundation.org>,
	<Nicolas.Ferre@microchip.com>, <johannes@sipsolutions.net>,
	<Sripad.Balwadgi@microchip.com>
Subject: Re: [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation
Date: Wed, 24 Jun 2020 05:26:49 +0000
Message-ID: <d9ab0945-f993-c12e-bfcf-d1467b2b683b@microchip.com> (raw)
In-Reply-To: <202006232255.SJ9vbMlt%lkp@intel.com>



On 23/06/20 8:22 pm, kernel test robot wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on a15a20acc980342c97d804c5fae1cfc0cd7712a9]
> 
> url:    https://github.com/0day-ci/linux/commits/Ajay-Kathat-microchip-com/wilc1000-move-out-of-staging/20200623-190333
> base:    a15a20acc980342c97d804c5fae1cfc0cd7712a9
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/net/wireless/microchip/wilc1000/mon.c: In function 'wilc_wfi_init_mon_interface':
>>> drivers/net/wireless/microchip/wilc1000/mon.c:232:2: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
>      232 |  strncpy(wl->monitor_dev->name, name, IFNAMSIZ);
>          |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Though replacing 'strncpy' with 'strlcpy' will help to suppress this
warning but not sure if its true alarm because next line sets NULL
termination for string.
I agree 'strlcpy' is better candidate here and reduces one extra line.

> 
> vim +/strncpy +232 drivers/net/wireless/microchip/wilc1000/mon.c
> 
> daf8b5f14a7066 Ajay Singh 2020-06-23  216
> daf8b5f14a7066 Ajay Singh 2020-06-23  217  struct net_device *wilc_wfi_init_mon_interface(struct wilc *wl,
> daf8b5f14a7066 Ajay Singh 2020-06-23  218                                              const char *name,
> daf8b5f14a7066 Ajay Singh 2020-06-23  219                                              struct net_device *real_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  220  {
> daf8b5f14a7066 Ajay Singh 2020-06-23  221       struct wilc_wfi_mon_priv *priv;
> daf8b5f14a7066 Ajay Singh 2020-06-23  222
> daf8b5f14a7066 Ajay Singh 2020-06-23  223       /* If monitor interface is already initialized, return it */
> daf8b5f14a7066 Ajay Singh 2020-06-23  224       if (wl->monitor_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  225               return wl->monitor_dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  226
> daf8b5f14a7066 Ajay Singh 2020-06-23  227       wl->monitor_dev = alloc_etherdev(sizeof(struct wilc_wfi_mon_priv));
> daf8b5f14a7066 Ajay Singh 2020-06-23  228       if (!wl->monitor_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  229               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  230
> daf8b5f14a7066 Ajay Singh 2020-06-23  231       wl->monitor_dev->type = ARPHRD_IEEE80211_RADIOTAP;
> daf8b5f14a7066 Ajay Singh 2020-06-23 @232       strncpy(wl->monitor_dev->name, name, IFNAMSIZ);
> daf8b5f14a7066 Ajay Singh 2020-06-23  233       wl->monitor_dev->name[IFNAMSIZ - 1] = 0;
> daf8b5f14a7066 Ajay Singh 2020-06-23  234       wl->monitor_dev->netdev_ops = &wilc_wfi_netdev_ops;
> daf8b5f14a7066 Ajay Singh 2020-06-23  235       wl->monitor_dev->needs_free_netdev = true;
> daf8b5f14a7066 Ajay Singh 2020-06-23  236
> daf8b5f14a7066 Ajay Singh 2020-06-23  237       if (register_netdevice(wl->monitor_dev)) {
> daf8b5f14a7066 Ajay Singh 2020-06-23  238               netdev_err(real_dev, "register_netdevice failed\n");
> daf8b5f14a7066 Ajay Singh 2020-06-23  239               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  240       }
> daf8b5f14a7066 Ajay Singh 2020-06-23  241       priv = netdev_priv(wl->monitor_dev);
> daf8b5f14a7066 Ajay Singh 2020-06-23  242       if (!priv)
> daf8b5f14a7066 Ajay Singh 2020-06-23  243               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  244
> daf8b5f14a7066 Ajay Singh 2020-06-23  245       priv->real_ndev = real_dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  246
> daf8b5f14a7066 Ajay Singh 2020-06-23  247       return wl->monitor_dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  248  }
> daf8b5f14a7066 Ajay Singh 2020-06-23  249
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 

  reply index

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 11:00 [PATCH v7 00/17] wilc1000: move out of staging Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 01/17] wilc1000: add hif.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 02/17] wilc1000: add hif.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 03/17] wilc1000: add wlan_if.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 04/17] wilc1000: add wlan_cfg.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 05/17] wilc1000: add wlan_cfg.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 06/17] wilc1000: add cfg80211.c Ajay.Kathat
2020-06-24  9:00   ` Johannes Berg
2020-06-23 11:00 ` [PATCH v7 07/17] wilc1000: add cfg80211.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 08/17] wilc1000: add netdev.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 09/17] wilc1000: add netdev.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 10/17] wilc1000: add mon.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 12/17] wilc1000: add wlan.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 11/17] wilc1000: add spi.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 13/17] wilc1000: add wlan.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 15/17] wilc1000: add fw.h Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 14/17] wilc1000: add sdio.c Ajay.Kathat
2020-06-23 11:00 ` [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat
2020-06-23 14:52   ` kernel test robot
2020-06-24  5:26     ` Ajay.Kathat [this message]
2020-06-23 11:00 ` [PATCH v7 16/17] dt: bindings: net: add microchip,wilc1000.yaml Ajay.Kathat
2020-06-24  8:50 ` [PATCH v7 00/17] wilc1000: move out of staging Kalle Valo
2020-06-24  9:10   ` Greg KH
2020-06-24  9:49     ` Kalle Valo
2020-06-24 14:52       ` Greg KH
2020-06-26  5:34         ` Kalle Valo
2020-06-26 13:46           ` Greg KH
2020-07-02  7:05             ` Kalle Valo
2020-06-29 13:26 ` Pali Rohár
2020-06-30  3:17   ` Ajay.Kathat
2020-07-01  7:55     ` Pali Rohár
2020-07-01  7:56       ` Pali Rohár
2020-07-06  8:12       ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ab0945-f993-c12e-bfcf-d1467b2b683b@microchip.com \
    --to=ajay.kathat@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Sripad.Balwadgi@microchip.com \
    --cc=Venkateswara.Kaja@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git