From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E41EC433E2 for ; Sun, 6 Sep 2020 16:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7A3120708 for ; Sun, 6 Sep 2020 16:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729015AbgIFQEw (ORCPT ); Sun, 6 Sep 2020 12:04:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbgIFQEn (ORCPT ); Sun, 6 Sep 2020 12:04:43 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF7F4C061573 for ; Sun, 6 Sep 2020 09:04:30 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kEx9V-00GzVa-NR; Sun, 06 Sep 2020 18:04:25 +0200 Message-ID: Subject: Re: [PATCH v2 00/22] add support for S1G association From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless , Jouni Malinen Date: Sun, 06 Sep 2020 18:04:24 +0200 In-Reply-To: <20200831205600.21058-1-thomas@adapt-ip.com> References: <20200831205600.21058-1-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote: > > Note the mac80211_hwsim S1G support introduces a regression in a few > hostap hwsim tests. This is because when processing the reported bands, > hostap assumes freq < 4000 is 11b, and the actual 11b/g band is > overwritten by the S1G band info. Though it does count as a userspace > regression, I'm not sure there is much to do about it besides apply a > small patch to hostapd which treats freq < 2000 as an unknown band. > > After the hostap workaround > (https://lists.infradead.org/pipermail/hostap/2020-August/038748.html), > these patches continue to pass the hwsim tests as well as HEAD. That sounds like we could "hack around" it by sending the S1G data first, and then the 2.4 GHz, so the latter overwrites it on broken versions? Not sure it's worth it though, I'd say it depends a bit on what real hardware plans are? I mean, if it's only hwsim for now ... who cares? And if it's going to be special hardware that only does S1G, then also meh, you need newer versions to support it, big deal. But if OTOH a commonly used chipset like e.g. ath9k or ath10k will get S1G support, then that'd be more relevant? johannes