From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EDEC433EF for ; Fri, 7 Jan 2022 03:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbiAGDyw (ORCPT ); Thu, 6 Jan 2022 22:54:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbiAGDyv (ORCPT ); Thu, 6 Jan 2022 22:54:51 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92BC0C061245; Thu, 6 Jan 2022 19:54:51 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 01BCF4212E; Fri, 7 Jan 2022 03:54:41 +0000 (UTC) Message-ID: Date: Fri, 7 Jan 2022 12:54:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 08/35] brcmfmac: of: Fetch Apple properties Content-Language: en-US To: Andy Shevchenko Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , "open list:TI WILINK WIRELES..." , netdev , devicetree , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , SHA-cyfmac-dev-list@infineon.com References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-9-marcan@marcan.st> From: Hector Martin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022/01/04 20:17, Andy Shevchenko wrote: > On Tue, Jan 4, 2022 at 9:28 AM Hector Martin wrote: >> >> On Apple ARM64 platforms, firmware selection requires two properties >> that come from system firmware: the module-instance (aka "island", a >> codename representing a given hardware platform) and the antenna-sku. >> We map Apple's module codenames to board_types in the form >> "apple,". >> >> The mapped board_type is added to the DTS file in that form, while the >> antenna-sku is forwarded by our bootloader from the Apple Device Tree >> into the FDT. Grab them from the DT so firmware selection can use >> them. > >> + /* Apple ARM64 platforms have their own idea of board type, passed in >> + * via the device tree. They also have an antenna SKU parameter >> + */ >> + if (!of_property_read_string(np, "brcm,board-type", &prop)) >> + settings->board_type = devm_kstrdup(dev, prop, GFP_KERNEL); >> + >> + if (!of_property_read_string(np, "apple,antenna-sku", &prop)) >> + settings->antenna_sku = devm_kstrdup(dev, prop, GFP_KERNEL); > > No error checks? > But hold on, why do you need to copy them? Are you expecting this to be in DTO? Yeah, I was wondering about that... indeed it shouldn't be necessary to copy them. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub