From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3379C433EF for ; Wed, 19 Jan 2022 15:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355708AbiASPVv (ORCPT ); Wed, 19 Jan 2022 10:21:51 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:35168 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1355310AbiASPVl (ORCPT ); Wed, 19 Jan 2022 10:21:41 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20JCnbo7014959; Wed, 19 Jan 2022 16:21:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=m/aWoxbwO4ww33sxaSzrOIlxUKriBNkq4+frD3/0F5Y=; b=aUlpneYD1/Myb/Bi5Sf2uaY7bPgcTvI5O4fx5VCC7EhIC+iSqb+ce3LtpyCtgSKUgiUB C8VdKQEXzQvGAZERCdTDVWKDG0MKpTeORJEbfNMS3LP95/TB3jU9UhuP+QV46DGbbsqR E45Je0X5Rd5P67ppfhNt7Wog1Rv2AWHpyFGYl9gTGYnidnBMb/yLh83KZdRZvpafudXh 254ZekIe3dgdgmu1NnXE0VkJAEJZa4JZZv4/Q3zXj0oyTQlpivYViygkK1/C52A91o8X vW/VbK+o6cKSp09BWrKsVnnWEZPGfR+jufJ6BVL41J2lp5FAYTM1kgfRFg5rWI8vM4Qm 0w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3dpf2vam04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jan 2022 16:21:36 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 82DD510002A; Wed, 19 Jan 2022 16:21:35 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node1.st.com [10.75.127.4]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E3E5921BF59; Wed, 19 Jan 2022 16:21:34 +0100 (CET) Received: from lmecxl0889.lme.st.com (10.75.127.44) by SFHDAG2NODE1.st.com (10.75.127.4) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Wed, 19 Jan 2022 16:21:32 +0100 Subject: Re: [PATCH] dt-bindings: Improve phandle-array schemas To: Rob Herring , CC: , Damien Le Moal , Herbert Xu , "David S. Miller" , Chun-Kuang Hu , Philipp Zabel , Laurent Pinchart , Kieran Bingham , Vinod Koul , Georgi Djakov , Thomas Gleixner , Marc Zyngier , Joerg Roedel , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Mauro Carvalho Chehab , Krzysztof Kozlowski , Jakub Kicinski , Wolfgang Grandegger , Marc Kleine-Budde , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Kalle Valo , Viresh Kumar , Stephen Boyd , Kishon Vijay Abraham I , Linus Walleij , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Sebastian Reichel , Mark Brown , Mathieu Poirier , Daniel Lezcano , Zhang Rui , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Sudeep Holla , Geert Uytterhoeven , , , , , , , , , , , , , , , , , References: <20220119015038.2433585-1-robh@kernel.org> From: Arnaud POULIQUEN Message-ID: Date: Wed, 19 Jan 2022 16:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220119015038.2433585-1-robh@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE1.st.com (10.75.127.4) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-19_08,2022-01-19_01,2021-12-02_01 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello Rob, On 1/19/22 2:50 AM, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually describes it. > > The array of phandles case boils down to needing: > > items: > maxItems: 1 > > The phandle plus args cases should typically take this form: > > items: > - items: > - description: A phandle > - description: 1st arg cell > - description: 2nd arg cell > > With this change, some examples need updating so that the bracketing of > property values matches the schema. > > Cc: Damien Le Moal > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: Vinod Koul > Cc: Georgi Djakov > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Pavel Machek > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Florian Fainelli > Cc: Vladimir Oltean > Cc: Kalle Valo > Cc: Viresh Kumar > Cc: Stephen Boyd > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Rafael J. Wysocki" > Cc: Kevin Hilman > Cc: Ulf Hansson > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Mathieu Poirier > Cc: Daniel Lezcano > Cc: Zhang Rui > Cc: Greg Kroah-Hartman > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Sudeep Holla > Cc: Geert Uytterhoeven > Cc: linux-ide@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: dmaengine@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: iommu@lists.linux-foundation.org > Cc: linux-leds@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-can@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Cc: linux-phy@lists.infradead.org > Cc: linux-gpio@vger.kernel.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-remoteproc@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring > --- [...] > .../bindings/remoteproc/st,stm32-rproc.yaml | 33 ++++++-- [...] > diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > index b587c97c282b..be3d9b0e876b 100644 > --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > @@ -29,17 +29,22 @@ properties: > > st,syscfg-holdboot: > description: remote processor reset hold boot > - - Phandle of syscon block. > - - The offset of the hold boot setting register. > - - The field mask of the hold boot. > $ref: "/schemas/types.yaml#/definitions/phandle-array" > - maxItems: 1 > + items: > + - items: > + - description: Phandle of syscon block > + - description: The offset of the hold boot setting register > + - description: The field mask of the hold boot > > st,syscfg-tz: > description: > Reference to the system configuration which holds the RCC trust zone mode > $ref: "/schemas/types.yaml#/definitions/phandle-array" > - maxItems: 1 > + items: > + - items: > + - description: Phandle of syscon block > + - description: FIXME > + - description: FIXME - description: The offset of the trust zone setting register - description: The field mask of the trust zone state > > interrupts: > description: Should contain the WWDG1 watchdog reset interrupt > @@ -93,20 +98,32 @@ properties: > $ref: "/schemas/types.yaml#/definitions/phandle-array" > description: | > Reference to the system configuration which holds the remote > - maxItems: 1 > + items: > + - items: > + - description: Phandle of syscon block > + - description: FIXME > + - description: FIXME - description: The offset of the power setting register - description: The field mask of the PDDS selection > > st,syscfg-m4-state: > $ref: "/schemas/types.yaml#/definitions/phandle-array" > description: | > Reference to the tamp register which exposes the Cortex-M4 state. > - maxItems: 1 > + items: > + - items: > + - description: Phandle of syscon block with the tamp register > + - description: FIXME > + - description: FIXME - description: The offset of the tamp register - description: The field mask of the Cortex-M4 state > > st,syscfg-rsc-tbl: > $ref: "/schemas/types.yaml#/definitions/phandle-array" > description: | > Reference to the tamp register which references the Cortex-M4 > resource table address. > - maxItems: 1 > + items: > + - items: > + - description: Phandle of syscon block with the tamp register > + - description: FIXME > + - description: FIXME - description: The offset of the tamp register - description: The field mask of the Cortex-M4 resource table address Please tell me if you prefer that I fix this in a dedicated patch. Thanks, Arnaud