branch: fmac-molton-patches checking patch: a6d80ee brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb() WARNING: line over 80 characters #24: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:233: +static inline int brcmf_sdiod_f0_writeb(struct sdio_func *func, u8 byte, uint regaddr) WARNING: line over 80 characters #34: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:271: + ret = brcmf_sdiod_f0_writeb(func, *(u8 *)data, addr); total: 0 errors, 2 warnings, 0 checks, 18 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: f86e392 brcmfmac: Register sizes on hardware are not dependent on compiler types total: 0 errors, 0 warnings, 0 checks, 79 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 700bd76 brcmfmac: Split brcmf_sdiod_regrw_helper() up. CHECK: Alignment should match open parenthesis #28: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:304: +static int brcmf_sdiod_reg_write(struct brcmf_sdio_dev *sdiodev, u32 addr, + u8 regsz, void *data) CHECK: braces {} should be used on all arms of this statement #48: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:335: + if (ret == -ENOMEDIUM) [...] + else if (ret != 0) { [...] WARNING: networking block comments don't use an empty /* line, use /* Comment... #52: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:339: + /* + * SleepCSR register access can fail when CHECK: Alignment should match open parenthesis #68: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:355: +static int brcmf_sdiod_reg_read(struct brcmf_sdio_dev *sdiodev, u32 addr, + u8 regsz, void *data) WARNING: networking block comments don't use an empty /* line, use /* Comment... #78: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:365: + /* + * figure out how to read the register based on address range CHECK: Alignment should match open parenthesis #128: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:422: + brcmf_sdiod_regwb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr[i], + &err); total: 0 errors, 2 warnings, 4 checks, 151 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: cc14ab9 brcmfmac: Clean up brcmf_sdiod_set_sbaddr_window() ERROR: space prohibited after that open parenthesis '(' #39: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:418: + for ( i = 0 ; i < 3 && !err ; i++, addr >>= 8 ) ERROR: space prohibited before that close parenthesis ')' #39: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:418: + for ( i = 0 ; i < 3 && !err ; i++, addr >>= 8 ) WARNING: line over 80 characters #40: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:419: + brcmf_sdiod_regwb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, CHECK: Alignment should match open parenthesis #41: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:420: + brcmf_sdiod_regwb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, &err); total: 2 errors, 1 warnings, 1 checks, 36 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 6dcb81a brcmfmac: Remove dead IO code total: 0 errors, 0 warnings, 0 checks, 66 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 0824f63 brcmfmac: Remove bandaid for SleepCSR total: 0 errors, 0 warnings, 0 checks, 38 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: e44c19c4 brcmfmac: Remove brcmf_sdiod_request_data() ERROR: space prohibited after that open parenthesis '(' #37: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:244: + for ( i = 0 ; i < 3 && !err ; i++, addr >>= 8 ) ERROR: space prohibited before that close parenthesis ')' #37: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:244: + for ( i = 0 ; i < 3 && !err ; i++, addr >>= 8 ) WARNING: line over 80 characters #38: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:245: + brcmf_sdiod_regwb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, CHECK: Alignment should match open parenthesis #39: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:246: + brcmf_sdiod_regwb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, + &err); WARNING: line over 80 characters #158: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:305: + ret = brcmf_sdiod_f0_writeb(sdiodev->func[0], *(u8 *)data, addr); ERROR: else should follow close brace '}' #160: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:307: + } + else { CHECK: Unbalanced braces around else statement #160: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:307: + else { ERROR: switch and case should be at the same indent #161: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:308: + switch (regsz) { + case 1: [...] + case 4: [...] + default: WARNING: line over 80 characters #163: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:310: + sdio_writeb(sdiodev->func[1], *(u8 *)data, addr, &ret); WARNING: line over 80 characters #172: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:317: + sdio_writel(sdiodev->func[1], *(u32 *)data, addr, &ret); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #175: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:320: + BUG(); ERROR: else should follow close brace '}' #261: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:347: } + else { CHECK: Unbalanced braces around else statement #261: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:347: + else { ERROR: switch and case should be at the same indent #262: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:348: + switch (regsz) { + case 1: [...] + case 4: [...] + default: WARNING: line over 80 characters #264: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:350: + *(u8 *)data = sdio_readb(sdiodev->func[1], addr, &ret); WARNING: line over 80 characters #273: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:357: + *(u32 *)data = sdio_readl(sdiodev->func[1], addr, &ret); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #276: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:360: + BUG(); total: 6 errors, 8 warnings, 3 checks, 317 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 39e5bf46 brcmfmac: Fix uninitialised variable total: 0 errors, 0 warnings, 0 checks, 8 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 493e6b8 brcmfmac: Remove noisy debugging. total: 0 errors, 0 warnings, 0 checks, 32 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 5496c99 brcmfmac: Rename bcmerror to err CHECK: Alignment should match open parenthesis #43: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:790: + err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_1, write, sdaddr, pkt); total: 0 errors, 0 warnings, 1 checks, 37 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: d900b87 brcmfmac: Split brcmf_sdiod_buffrw function up. CHECK: Alignment should match open parenthesis #25: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:419: +static int brcmf_sdiod_buff_read(struct brcmf_sdio_dev *sdiodev, uint fn, + u32 addr, struct sk_buff *pkt) CHECK: Alignment should match open parenthesis #41: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:430: + err = sdio_memcpy_fromio(sdiodev->func[fn], + ((u8 *)(pkt->data)), addr, req_sz); CHECK: Alignment should match open parenthesis #47: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:434: + err = sdio_readsb(sdiodev->func[fn], + ((u8 *)(pkt->data)), addr, req_sz); CHECK: Alignment should match open parenthesis #56: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:443: +static int brcmf_sdiod_buff_write(struct brcmf_sdio_dev *sdiodev, uint fn, + u32 addr, struct sk_buff *pkt) CHECK: Alignment should match open parenthesis #89: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:688: + err = brcmf_sdiod_buff_read(sdiodev, SDIO_FUNC_2, addr, pktq->next); CHECK: Alignment should match open parenthesis #96: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:694: + err = brcmf_sdiod_buff_read(sdiodev, SDIO_FUNC_2, addr, glom_skb); CHECK: Alignment should match open parenthesis #126: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:754: + err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2, addr, skb); CHECK: Alignment should match open parenthesis #140: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:810: + err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_1, + sdaddr, pkt); ERROR: else should follow close brace '}' #142: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:812: + } + else { CHECK: Unbalanced braces around else statement #142: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:812: + else { CHECK: Alignment should match open parenthesis #144: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:814: + err = brcmf_sdiod_buff_read(sdiodev, SDIO_FUNC_1, + sdaddr, pkt); total: 1 errors, 0 warnings, 10 checks, 124 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 21b43d2 brcmfmac: Replace old IO functions with simpler ones. WARNING: line over 80 characters #41: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:144: + brcmf_sdiod_writeb(sdiodev, SBSDIO_GPIO_SELECT, 0xf, &ret); WARNING: line over 80 characters #59: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:158: + brcmf_sdiod_func0_wb(sdiodev, SDIO_CCCR_BRCM_SEPINT, data, &ret); WARNING: line over 80 characters #79: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:243: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, CHECK: Alignment should match open parenthesis #80: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:244: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, addr & 0xff, &err); CHECK: Alignment should match open parenthesis #230: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:286: +void brcmf_sdiod_writel(struct brcmf_sdio_dev *sdiodev, u32 addr, u32 data, int *ret) WARNING: line over 80 characters #291: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:723: + rd_val = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_FUNC1_SLEEPCSR, &err); WARNING: line over 80 characters #301: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:733: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_SLEEPCSR, wr_val, &err); WARNING: line over 80 characters #311: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:769: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, clkreq, &err); WARNING: line over 80 characters #320: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:776: + clkctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, &err); WARNING: line over 80 characters #330: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:785: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, CHECK: Alignment should match open parenthesis #331: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:786: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, + &err); WARNING: line over 80 characters #341: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:794: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, CHECK: Alignment should match open parenthesis #342: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:795: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, + &err); WARNING: line over 80 characters #351: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:802: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, CHECK: Alignment should match open parenthesis #352: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:803: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, + &err); WARNING: line over 80 characters #356: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:805: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, CHECK: Alignment should match open parenthesis #357: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:806: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, + &err); WARNING: line over 80 characters #375: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:847: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, CHECK: Alignment should match open parenthesis #376: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:848: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, + &err); WARNING: line over 80 characters #380: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:850: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, CHECK: Alignment should match open parenthesis #381: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:851: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, + &err); WARNING: line over 80 characters #387: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:855: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, clkreq, &err); CHECK: Alignment should match open parenthesis #403: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:951: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, WARNING: line over 80 characters #412: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1167: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_FRAMECTRL, SFC_RF_TERM, &err); WARNING: line over 80 characters #421: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1172: + hi = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_FUNC1_RFRAMEBCHI, &err); WARNING: line over 80 characters #422: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1173: + lo = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_FUNC1_RFRAMEBCLO, &err); CHECK: Alignment should match open parenthesis #452: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2435: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, (saveclk | SBSDIO_FORCE_HT), &err); WARNING: line over 80 characters #479: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2530: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, &err); WARNING: line over 80 characters #485: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2534: + clkctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, &err); WARNING: line over 80 characters #493: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2540: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, CHECK: Alignment should match open parenthesis #494: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2541: + devctl = brcmf_sdiod_readb(bus->sdiodev, SBSDIO_DEVICE_CTL, + &err); WARNING: line over 80 characters #498: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2543: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, CHECK: Alignment should match open parenthesis #499: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2544: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_DEVICE_CTL, devctl, + &err); CHECK: Alignment should match open parenthesis #525: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3345: + brcmf_sdiod_func0_wb(bus->sdiodev, SDIO_CCCR_BRCM_CARDCAP, (SDIO_CCCR_BRCM_CARDCAP_CMD14_SUPPORT | WARNING: line over 80 characters #534: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3353: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, SBSDIO_FORCE_HT, CHECK: Alignment should match open parenthesis #535: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3354: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, SBSDIO_FORCE_HT, + &err); WARNING: line over 80 characters #554: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3386: + brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_SLEEPCSR, val, &err); CHECK: Alignment should match open parenthesis #564: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3548: + devpend = brcmf_sdiod_func0_rb(bus->sdiodev, SDIO_CCCR_INTx, WARNING: line over 80 characters #608: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3723: + SPINWAIT(((clkval = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, NULL)), CHECK: Alignment should match open parenthesis #609: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3724: + SPINWAIT(((clkval = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, NULL)), !SBSDIO_ALPAV(clkval)), WARNING: line over 80 characters #667: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3813: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, BRCMF_INIT_CLKCTL1, &err); WARNING: line over 80 characters #671: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3815: + clkctl = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, &err); CHECK: Alignment should match open parenthesis #714: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4017: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, (saveclk | SBSDIO_FORCE_HT), &err); WARNING: line over 80 characters #732: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4050: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, saveclk, &err); WARNING: line over 80 characters #793: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h:311: +void brcmf_sdiod_writel(struct brcmf_sdio_dev *sdiodev, u32 addr, u32 data, int *ret); total: 0 errors, 28 warnings, 17 checks, 718 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 749546c brcmfmac: Tidy register definitions a little total: 0 errors, 0 warnings, 0 checks, 23 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 75e0eaf brcmfmac: Remove brcmf_sdiod_addrprep() ERROR: spaces required around that '>>=' (ctx:VxV) #57: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:242: + for (i = 0 ; i < 3 && !err ; i++, v>>=8) ^ WARNING: line over 80 characters #58: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:243: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_SBADDRLOW + i, v & 0xff, &err); ERROR: space required before the open parenthesis '(' #60: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:245: + if(!err) total: 2 errors, 1 warnings, 0 checks, 157 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 6cb63bf brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window() total: 0 errors, 0 warnings, 0 checks, 11 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: a753a68 brcmfmac: Cleanup offsetof() total: 0 errors, 0 warnings, 0 checks, 104 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 184c5bf brcmfmac: Remove unused macro. total: 0 errors, 0 warnings, 0 checks, 8 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 6a89ddd brcmfmac: Rename SOC_AI to SOC_AXI ERROR: switch and case should be at the same indent #34: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:930: + switch(socitype) { + case SOCI_SB: ERROR: space required before the open parenthesis '(' #34: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:930: + switch(socitype) { total: 2 errors, 0 warnings, 0 checks, 34 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: ea8d20d brcmfmac: Get rid of chip_priv and core_priv structs WARNING: printk() should include KERN_ facility level #464: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:900: + printk("found %s chip: BCM%s, rev=%d\n", CHECK: Alignment should match open parenthesis #465: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:901: + printk("found %s chip: BCM%s, rev=%d\n", + socitype == SOCI_SB ? "SB" : "AXI", ci->name, CHECK: Alignment should match open parenthesis #934: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.h:51: + void (*resetcore)(struct brcmf_core *core, u32 prereset, u32 reset, + u32 postreset); total: 0 errors, 1 warnings, 2 checks, 910 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: d6a329b brcmfmac: Whitespace patch CHECK: Blank lines aren't necessary after an open brace '{' #159: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:459: BCMA_RESET_CTL_RESET) { + total: 0 errors, 0 warnings, 1 checks, 221 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 224a0e3 brcmfmac: Simplify chip probe routine CHECK: Alignment should match open parenthesis #42: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:475: +static struct brcmf_core *__brcmf_chip_add_core(struct brcmf_chip *ci, u16 coreid, u32 base, CHECK: Alignment should match open parenthesis #59: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:495: +static struct brcmf_core *brcmf_chip_add_sb_core(struct brcmf_chip *ci, + u16 coreid, u32 base, CHECK: Alignment should match open parenthesis #79: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:515: +static struct brcmf_core *brcmf_chip_add_axi_core(struct brcmf_chip *ci, + u16 coreid, u32 base, CHECK: Please don't use multiple blank lines #92: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:528: + + WARNING: line over 80 characters #107: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:929: + return -ENOMEM; //FIXME - and cleanup the allocated cores? ERROR: space prohibited before that ',' (ctx:WxW) #125: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:946: + { 0 , 0}, ^ CHECK: Alignment should match open parenthesis #129: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:950: +static int brcmf_chip_add_static(struct brcmf_chip *ci, + struct brcmf_chip_desc *desc) ERROR: space prohibited before that close parenthesis ')' #131: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:952: + for ( ; desc->id ; desc++ ) CHECK: Please don't use multiple blank lines #139: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:960: + + ERROR: switch and case should be at the same indent #168: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:988: + switch(ci->chip) { + case BRCM_CC_4329_CHIP_ID: [...] + default: ERROR: space required before the open parenthesis '(' #168: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:988: + switch(ci->chip) { ERROR: space required before the open parenthesis '(' #177: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:997: + if(!ret) total: 5 errors, 1 warnings, 6 checks, 201 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: b634bd0 brcmfmac: Rename axi functions for clarity. CHECK: Alignment should match open parenthesis #33: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:344: +static void brcmf_chip_axi_coredisable(struct brcmf_core *core, u32 prereset, u32 reset) CHECK: Alignment should match open parenthesis #42: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:436: +static void brcmf_chip_axi_resetcore(struct brcmf_core *core, u32 prereset, u32 reset, u32 postreset) total: 0 errors, 0 warnings, 2 checks, 44 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: f892dcf brcmfmac: HUGE cleanup of IO access functions. WARNING: Comparisons should place the constant on the right side of the test #101: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:272: + return SSB_TMSLOW_CLOCK == val; ERROR: space required before the open parenthesis '(' #115: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:282: + if((val & BCMA_IOCTL_FGC) || !(val & BCMA_IOCTL_CLK)) CHECK: Alignment should match open parenthesis #132: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:295: +static void brcmf_chip_sb_core_disable(struct brcmf_core *core, u32 prereset, u32 reset) WARNING: networking block comments don't use an empty /* line, use /* Comment... #163: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:314: + /* + * Set target reject and spin until busy is clear ERROR: that open brace { should be on the previous line #200: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:330: + if (val & SSB_IDLOW_INITIATOR) + { CHECK: Alignment should match open parenthesis #208: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:335: + brcmf_set_bits_post(ci, CORE_SB(base, sbimstate), + SSB_IMSTATE_REJECT); CHECK: Alignment should match open parenthesis #227: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:349: + brcmf_writelp(ci, CORE_SB(base, sbtmstatelow), + SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK | CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt #233: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:352: + udelay(10); CHECK: Alignment should match open parenthesis #246: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:360: + brcmf_clear_bits(ci, CORE_SB(base, sbimstate), + SSB_IMSTATE_REJECT); CHECK: Alignment should match open parenthesis #253: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:365: + brcmf_writel(ci, CORE_SB(base, sbtmstatelow), + SSB_TMSLOW_REJECT | SSB_TMSLOW_RESET); CHECK: Alignment should match open parenthesis #260: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:371: +static void brcmf_chip_axi_core_disable(struct brcmf_core *core, u32 prereset, u32 reset) CHECK: Alignment should match open parenthesis #279: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:384: + brcmf_writelp(ci, core->wrapbase + BCMA_IOCTL, prereset | BCMA_IOCTL_FGC | BCMA_IOCTL_CLK); WARNING: networking block comments don't use an empty /* line, use /* Comment... #294: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:392: + /* + * Wait till reset is 1 CHECK: Alignment should match open parenthesis #304: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:400: + brcmf_writelp(ci, core->wrapbase + BCMA_IOCTL, reset | BCMA_IOCTL_FGC | BCMA_IOCTL_CLK); CHECK: Alignment should match open parenthesis #311: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:404: +static void brcmf_chip_sb_reset_core(struct brcmf_core *core, u32 prereset, u32 reset, u32 postreset) CHECK: Alignment should match open parenthesis #332: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:422: + brcmf_writelp(ci, CORE_SB(base, sbtmstatelow), SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK | CHECK: Alignment should match open parenthesis #364: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:442: + brcmf_writelp(ci, CORE_SB(base, sbtmstatelow), SSB_TMSLOW_FGC | SSB_TMSLOW_CLOCK); CHECK: Alignment should match open parenthesis #383: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:453: +static void brcmf_chip_axi_reset_core(struct brcmf_core *core, u32 prereset, u32 reset, u32 postreset) CHECK: Alignment should match open parenthesis #427: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:471: + brcmf_writelp(ci, core->wrapbase + BCMA_IOCTL, + postreset | BCMA_IOCTL_CLK); ERROR: trailing whitespace #617: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:975: +^Isnprintf(ci->name, sizeof(ci->name), $ CHECK: Alignment should match open parenthesis #618: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:976: + snprintf(ci->name, sizeof(ci->name), + (ci->chip > 0xa000 || ci->chip < 0x4000) ? "%d" : "%x", ERROR: switch and case should be at the same indent #626: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:981: switch(socitype) { [...] + case SOCI_AXI: [...] + default: ERROR: switch and case should be at the same indent #637: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:984: + switch(ci->chip) { + case BRCM_CC_4329_CHIP_ID: [...] + default: ERROR: space required before the open parenthesis '(' #637: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:984: + switch(ci->chip) { WARNING: line over 80 characters #639: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:986: + ret = brcmf_chip_add_static(ci, brcmf_4329); ERROR: space required before the open parenthesis '(' #648: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:993: + if(!ret) WARNING: printk() should include KERN_ facility level #708: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1034: + printk("Found BCM%s, %s backplane, rev=%d\n", ci->name, CHECK: Alignment should match open parenthesis #709: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1035: + printk("Found BCM%s, %s backplane, rev=%d\n", ci->name, + socitype == SOCI_SB ? "SB" : "AXI", WARNING: line over 80 characters #747: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1090: + val = brcmf_readl(chip, CORE_CC_REG(pmu->base, pmucapabilities)); WARNING: line over 80 characters #821: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:1396: + reg = brcmf_readl(ci, CORE_CC_REG(pmu->base, pmucapabilities_ext)); total: 7 errors, 7 warnings, 16 checks, 790 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 4d84cd0 brcmfmac: Rename chip.ctx -> chip.bus_priv total: 0 errors, 0 warnings, 0 checks, 109 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: ad26fe2 brcmfmac: Remove repeated calls to brcmf_chip_get_core() total: 0 errors, 0 warnings, 0 checks, 96 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 06fbaca brcmfmac: General cleaning up. whitespace and comments fix. CHECK: Blank lines aren't necessary after an open brace '{' #58: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3765: + addr == CORE_CC_REG(SI_ENUM_BASE, chipid)) { + total: 0 errors, 0 warnings, 1 checks, 60 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 0b3f3fb brcmfmac: Remove {r,w}_sdreg32 CHECK: Alignment should match open parenthesis #68: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1065: + brcmf_sdiod_writel(sdiod, core->base + __sd_reg(tosbmailbox), + SMB_INT_ACK, &ret); CHECK: Alignment should match open parenthesis #90: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1176: + brcmf_sdiod_writel(sdiod, core->base + __sd_reg(tosbmailbox), + SMB_NAK, &err); WARNING: line over 80 characters #108: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2302: + __sd_reg(intstatus), &ret); WARNING: line over 80 characters #134: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2409: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(hostintmask), 0, NULL); CHECK: Alignment should match open parenthesis #145: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2430: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(intstatus), + local_hostintmask, NULL); CHECK: Alignment should match open parenthesis #164: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2552: + brcmf_sdiod_writel(sdiod, core->base + __sd_reg(intstatus), + I_HMB_FC_CHANGE, &err); WARNING: line over 80 characters #166: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2554: + newstatus = brcmf_sdiod_readl(sdiod, core->base + __sd_reg(intstatus), CHECK: Alignment should match open parenthesis #167: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2555: + newstatus = brcmf_sdiod_readl(sdiod, core->base + __sd_reg(intstatus), + &err); WARNING: line over 80 characters #209: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4022: + SDPCM_PROT_VERSION << SMB_DATA_VERSION_SHIFT, NULL); CHECK: Alignment should match open parenthesis #209: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4022: + brcmf_sdiod_writel(sdiod, core->base + __sd_reg(tosbmailboxdata), + SDPCM_PROT_VERSION << SMB_DATA_VERSION_SHIFT, NULL); CHECK: Alignment should match open parenthesis #220: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4034: + brcmf_sdiod_writel(sdiod, core->base + __sd_reg(hostintmask), + bus->hostintmask, NULL); total: 0 errors, 4 warnings, 7 checks, 192 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 456c68b brcmfmac: Rename buscore->core for consistency WARNING: line over 80 characters #30: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2473: + val = brcmf_sdiod_readl(bus->sdiodev, core->base + __sd_reg(intstatus), &ret); WARNING: line over 80 characters #39: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2483: + brcmf_sdiod_writel(bus->sdiodev, core->base + __sd_reg(intstatus), CHECK: Alignment should match open parenthesis #40: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2484: + brcmf_sdiod_writel(bus->sdiodev, core->base + __sd_reg(intstatus), + val, &ret); total: 0 errors, 2 warnings, 1 checks, 25 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 3b3d9e5 brcmfmac: stabilise the value of ->sbwad in use for some xfer routines. WARNING: line over 80 characters #66: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3824: + /* Pick up the CHIPCOMMON core info struct, used for bulk IO in bcmsdh.c */ total: 0 errors, 1 warnings, 0 checks, 50 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: c8c83ec brcmfmac: Correctly handle accesses to SDIO func0 total: 0 errors, 0 warnings, 0 checks, 22 lines checked Your patch has no obvious style problems and is ready for submission. checking patch: 623dcbe brcmfmac: Remove func0 from function array WARNING: 'doesnt' may be misspelled - perhaps 'doesn't'? #6: Linux doesnt pass you func0 as a function when probing - instead CHECK: Alignment should match open parenthesis #59: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3755: + if ((sdiodev->func[1]->device == SDIO_DEVICE_ID_BROADCOM_4335_4339 || + sdiodev->func[1]->device == SDIO_DEVICE_ID_BROADCOM_4339) && total: 0 errors, 1 warnings, 1 checks, 72 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 90a8fb6 brcmfmac: Replace function index with function pointer WARNING: line over 80 characters #26: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:151: + data |= SDIO_CCCR_IEN_FUNC1 | SDIO_CCCR_IEN_FUNC2 | SDIO_CCCR_IEN_BIT0; CHECK: Alignment should match open parenthesis #36: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:294: +static int brcmf_sdiod_buff_read(struct brcmf_sdio_dev *sdiodev, + struct sdio_func *func, CHECK: Alignment should match open parenthesis #49: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:306: + err = sdio_memcpy_fromio(func, ((u8 *)(pkt->data)), addr, + req_sz); CHECK: Alignment should match open parenthesis #64: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:318: +static int brcmf_sdiod_buff_write(struct brcmf_sdio_dev *sdiodev, + struct sdio_func *func, CHECK: Alignment should match open parenthesis #95: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:349: +static int brcmf_sdiod_sglist_rw(struct brcmf_sdio_dev *sdiodev, + struct sdio_func *func, CHECK: spaces preferred around that '<<' (ctx:VxV) #128: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:414: + mmc_cmd.arg |= (func->num == 1) ? 1<<26 : 0; ^ CHECK: Alignment should match open parenthesis #162: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:570: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func[2], addr, pktq->next); CHECK: Alignment should match open parenthesis #169: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:576: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func[2], addr, glom_skb); WARNING: line over 80 characters #177: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:585: + err = brcmf_sdiod_sglist_rw(sdiodev, sdiodev->func[2], false, addr, WARNING: line over 80 characters #186: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:617: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func[2], addr, mypkt); CHECK: Alignment should match open parenthesis #196: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:644: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func[2], addr, skb); WARNING: line over 80 characters #202: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:649: + err = brcmf_sdiod_sglist_rw(sdiodev, sdiodev->func[2], true, addr, CHECK: Alignment should match open parenthesis #212: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:700: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func[1], sdaddr, pkt); CHECK: Alignment should match open parenthesis #217: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:704: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func[1], sdaddr, pkt); CHECK: Prefer using the BIT macro #344: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h:48: +#define SDIO_CCCR_IEN_BIT0 (1 << 0) CHECK: Prefer using the BIT macro #345: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h:49: +#define SDIO_CCCR_IEN_FUNC1 (1 << 1) CHECK: Prefer using the BIT macro #346: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h:50: +#define SDIO_CCCR_IEN_FUNC2 (1 << 2) total: 0 errors, 4 warnings, 13 checks, 302 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: 45d0373 brcmfmac: Remove array of functions CHECK: Alignment should match open parenthesis #124: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:570: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func2, addr, pktq->next); CHECK: Alignment should match open parenthesis #131: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:576: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func2, addr, glom_skb); WARNING: line over 80 characters #139: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:585: + err = brcmf_sdiod_sglist_rw(sdiodev, sdiodev->func2, false, addr, WARNING: line over 80 characters #148: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:617: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func2, addr, mypkt); CHECK: Alignment should match open parenthesis #158: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:644: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func2, addr, skb); CHECK: Alignment should match open parenthesis #183: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:700: + err = brcmf_sdiod_buff_write(sdiodev, sdiodev->func1, sdaddr, pkt); CHECK: Alignment should match open parenthesis #188: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:704: + err = brcmf_sdiod_buff_read(sdiodev, sdiodev->func1, sdaddr, pkt); CHECK: Alignment should match open parenthesis #830: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3755: + if ((sdiodev->func1->device == SDIO_DEVICE_ID_BROADCOM_4335_4339 || + sdiodev->func1->device == SDIO_DEVICE_ID_BROADCOM_4339) && total: 0 errors, 2 warnings, 6 checks, 935 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. checking patch: ad1616c brcmfmac: Reduce the noise from repeatedly dereferencing common pointers WARNING: Use a single space after To: #13: to: ERROR: Unrecognized email address: '' #13: to: WARNING: line over 80 characters #270: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:705: + err = brcmf_sdiod_buff_write(sdiodev, func1, sdaddr, pkt); WARNING: line over 80 characters #275: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:708: + err = brcmf_sdiod_buff_read(sdiodev, func1, sdaddr, pkt); WARNING: line over 80 characters #486: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:701: + rd_val = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_SLEEPCSR, &err); WARNING: line over 80 characters #495: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:711: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_SLEEPCSR, wr_val, &err); WARNING: line over 80 characters #512: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:748: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, clkreq, &err); WARNING: line over 80 characters #520: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:755: + clkctl = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, &err); CHECK: Alignment should match open parenthesis #530: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:765: + devctl = brcmf_sdiod_readb(sdiodev, SBSDIO_DEVICE_CTL, &err); CHECK: Alignment should match open parenthesis #539: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:774: + brcmf_sdiod_writeb(sdiodev, SBSDIO_DEVICE_CTL, devctl, &err); CHECK: Alignment should match open parenthesis #548: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:782: + devctl = brcmf_sdiod_readb(sdiodev, SBSDIO_DEVICE_CTL, &err); CHECK: Alignment should match open parenthesis #552: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:785: + brcmf_sdiod_writeb(sdiodev, SBSDIO_DEVICE_CTL, devctl, &err); CHECK: Alignment should match open parenthesis #570: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:827: + devctl = brcmf_sdiod_readb(sdiodev, SBSDIO_DEVICE_CTL, &err); CHECK: Alignment should match open parenthesis #574: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:830: + brcmf_sdiod_writeb(sdiodev, SBSDIO_DEVICE_CTL, devctl, &err); WARNING: line over 80 characters #579: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:834: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, clkreq, &err); CHECK: Alignment should match open parenthesis #603: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:931: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, CHECK: Alignment should match open parenthesis #676: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1070: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(tosbmailbox), SMB_INT_ACK, &ret); CHECK: Alignment should match open parenthesis #715: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1182: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(tosbmailbox), SMB_NAK, &err); WARNING: line over 80 characters #1010: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2489: + val = brcmf_sdiod_readl(sdiodev, core->base + __sd_reg(intstatus), &ret); WARNING: line over 80 characters #1029: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2501: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(intstatus), val, &ret); WARNING: line over 80 characters #1065: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2534: + clkctl = brcmf_sdiod_readb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, &err); CHECK: Alignment should match open parenthesis #1073: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2541: + devctl = brcmf_sdiod_readb(sdiodev, SBSDIO_DEVICE_CTL, &err); CHECK: Alignment should match open parenthesis #1077: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2544: + brcmf_sdiod_writeb(sdiodev, SBSDIO_DEVICE_CTL, devctl, &err); CHECK: Alignment should match open parenthesis #1086: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2568: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(intstatus), I_HMB_FC_CHANGE, &err); CHECK: Alignment should match open parenthesis #1091: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2571: + newstatus = brcmf_sdiod_readl(sdiodev, + core->base + __sd_reg(intstatus), WARNING: line over 80 characters #1209: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2912: + rv = brcmf_sdiod_ramrw(sdiodev, false, addr, (u8 *)&sh_val, sizeof(u32)); WARNING: line over 80 characters #1217: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2918: + rv = brcmf_sdiod_ramrw(sdiodev, false, addr, (u8 *)&sh_val, sizeof(u32)); WARNING: line over 80 characters #1225: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2924: + rv = brcmf_sdiod_ramrw(sdiodev, false, addr, (u8 *)&sh_val, sizeof(u32)); CHECK: Alignment should match open parenthesis #1363: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3354: + brcmf_sdiod_func0_wb(sdiodev, SDIO_CCCR_BRCM_CARDCAP, (SDIO_CCCR_BRCM_CARDCAP_CMD14_SUPPORT | CHECK: Alignment should match open parenthesis #1372: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3363: + brcmf_sdiod_writeb(sdiodev, SBSDIO_FUNC1_CHIPCLKCSR, SBSDIO_FORCE_HT, &err); CHECK: Alignment should match open parenthesis #1447: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3564: + devpend = brcmf_sdiod_func0_rb(sdiodev, SDIO_CCCR_INTx, CHECK: Alignment should match open parenthesis #1582: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4059: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(tosbmailboxdata), SDPCM_PROT_VERSION << SMB_DATA_VERSION_SHIFT, NULL); CHECK: Alignment should match open parenthesis #1595: FILE: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:4071: + brcmf_sdiod_writel(sdiodev, core->base + __sd_reg(hostintmask), bus->hostintmask, NULL); total: 1 errors, 14 warnings, 18 checks, 1602 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Done!