From: Ping-Ke Shih <pkshih@realtek.com>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Bernie Huang <phhuang@realtek.com>
Subject: RE: [PATCH 3/6] rtw88: Add update beacon flow for AP mode
Date: Thu, 26 May 2022 00:03:52 +0000 [thread overview]
Message-ID: <e10c2c9b0c15479594703f2d03b0fa03@realtek.com> (raw)
In-Reply-To: <20220525230121.zk6xdjycxdhe62nw@core>
> -----Original Message-----
> From: Ondřej Jirman <megi@xff.cz>
> Sent: Thursday, May 26, 2022 7:01 AM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: tony0620emma@gmail.com; kvalo@kernel.org; linux-wireless@vger.kernel.org; Bernie Huang
> <phhuang@realtek.com>
> Subject: Re: [PATCH 3/6] rtw88: Add update beacon flow for AP mode
>
> Hello Ping-Ke,
>
> please see bugreport below:
>
> >
> > +static int rtw_ops_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
> > + bool set)
> > +{
> > + struct rtw_dev *rtwdev = hw->priv;
> > +
> > + mutex_lock(&rtwdev->mutex);
> > + rtw_fw_download_rsvd_page(rtwdev);
> > + mutex_unlock(&rtwdev->mutex);
>
> set_tim is supposed to be atomic. See:
> https://elixir.bootlin.com/linux/latest/source/include/net/mac80211.h#L3500
>
Thanks for pointing out.
We will fix it.
Ping-Ke
next prev parent reply other threads:[~2022-05-26 0:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:58 [PATCH 0/6] rtw88: 8821c: support AP mode Ping-Ke Shih
2022-04-07 9:58 ` [PATCH 1/6] rtw88: add ieee80211:sta_rc_update ops Ping-Ke Shih
2022-04-12 13:52 ` Kalle Valo
2022-04-07 9:58 ` [PATCH 2/6] rtw88: fix incorrect frequency reported Ping-Ke Shih
2022-04-07 9:58 ` [PATCH 3/6] rtw88: Add update beacon flow for AP mode Ping-Ke Shih
2022-05-25 23:01 ` Ondřej Jirman
2022-05-26 0:03 ` Ping-Ke Shih [this message]
2022-04-07 9:58 ` [PATCH 4/6] rtw88: 8821c: Enable TX report for management frames Ping-Ke Shih
2022-04-07 9:58 ` [PATCH 5/6] rtw88: do PHY calibration while starting AP Ping-Ke Shih
2022-04-07 9:58 ` [PATCH 6/6] rtw88: 8821c: fix debugfs rssi value Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10c2c9b0c15479594703f2d03b0fa03@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=phhuang@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).