From: Christian Lamparter <chunkeey@gmail.com>
To: Allen Pais <allen.cryptic@gmail.com>,
kvalo@codeaurora.org, kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 21:12:41 +0200 [thread overview]
Message-ID: <e22d8564-b4de-d8a2-e607-d6776db7b38b@gmail.com> (raw)
In-Reply-To: <20200817090637.26887-4-allen.cryptic@gmail.com>
Hello,
looking at the other patches in this series, I think this patch's
subject "ath:" tag was supposed to be "carl9170:"?
(so the full subject is:
"wireless: carl9170: convert tasklets to use new tasklet_setup() API")
On 2020-08-17 11:06, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Seems to work.
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/usb.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c
> index ead79335823a..e4eb666c6eea 100644
> --- a/drivers/net/wireless/ath/carl9170/usb.c
> +++ b/drivers/net/wireless/ath/carl9170/usb.c
> @@ -377,9 +377,9 @@ void carl9170_usb_handle_tx_err(struct ar9170 *ar)
> }
> }
>
> -static void carl9170_usb_tasklet(unsigned long data)
> +static void carl9170_usb_tasklet(struct tasklet_struct *t)
> {
> - struct ar9170 *ar = (struct ar9170 *) data;
> + struct ar9170 *ar = from_tasklet(ar, t, usb_tasklet);
>
> if (!IS_INITIALIZED(ar))
> return;
> @@ -1082,8 +1082,7 @@ static int carl9170_usb_probe(struct usb_interface *intf,
> init_completion(&ar->cmd_wait);
> init_completion(&ar->fw_boot_wait);
> init_completion(&ar->fw_load_wait);
> - tasklet_init(&ar->usb_tasklet, carl9170_usb_tasklet,
> - (unsigned long)ar);
> + tasklet_setup(&ar->usb_tasklet, carl9170_usb_tasklet);
>
> atomic_set(&ar->tx_cmd_urbs, 0);
> atomic_set(&ar->tx_anch_urbs, 0);
>
next prev parent reply other threads:[~2020-08-17 19:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:06 [PATCH 00/16] wirless: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 9:06 ` [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-27 10:15 ` Kalle Valo
[not found] ` <20200827101540.6589BC433CB@smtp.codeaurora.org>
2020-08-27 10:44 ` Allen Pais
2020-09-07 16:32 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 02/16] wireless: ath9k: " Allen Pais
2020-08-27 10:16 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 03/16] wireless: ath: " Allen Pais
2020-08-17 19:12 ` Christian Lamparter [this message]
2020-08-27 10:21 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 04/16] wireless: ath11k: " Allen Pais
2020-08-31 15:14 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 05/16] wireless: atmel: " Allen Pais
2020-08-27 13:23 ` [05/16] " Kalle Valo
2020-08-27 18:17 ` Kees Cook
2020-08-17 9:06 ` [PATCH 06/16] wireless: b43legacy: " Allen Pais
2020-08-17 9:06 ` [PATCH 07/16] wireless: brcm80211: " Allen Pais
2020-08-17 10:15 ` Arend Van Spriel
2020-08-17 9:06 ` [PATCH 08/16] wireless: ipw2x00: " Allen Pais
2020-08-17 9:06 ` [PATCH 09/16] wireless: iwlegacy: " Allen Pais
2020-08-17 9:06 ` [PATCH 10/16] wireless: intersil: " Allen Pais
2020-09-16 13:44 ` Lee Jones
2020-08-17 9:06 ` [PATCH 11/16] wireless: marvell: " Allen Pais
2020-08-17 9:06 ` [PATCH 12/16] wireless: mediatek: " Allen Pais
2020-09-01 9:25 ` Kalle Valo
2020-08-17 9:06 ` [PATCH 13/16] wireless: quantenna: " Allen Pais
2020-08-17 9:06 ` [PATCH 14/16] wireless: ralink: " Allen Pais
2020-08-17 9:06 ` [PATCH 15/16] wireless: realtek: " Allen Pais
2020-08-17 9:06 ` [PATCH 16/16] wireless: zydas: " Allen Pais
2020-08-18 5:44 ` [PATCH 00/16] wirless: convert tasklets to use new tasklet_setup() Jiri Slaby
2020-08-18 9:14 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22d8564-b4de-d8a2-e607-d6776db7b38b@gmail.com \
--to=chunkeey@gmail.com \
--cc=allen.cryptic@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).