From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5070C5B57A for ; Fri, 28 Jun 2019 13:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97EB520645 for ; Fri, 28 Jun 2019 13:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbfF1NEC (ORCPT ); Fri, 28 Jun 2019 09:04:02 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:50234 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfF1NEB (ORCPT ); Fri, 28 Jun 2019 09:04:01 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hgqXn-0001Ld-VO; Fri, 28 Jun 2019 15:04:00 +0200 Message-ID: Subject: Re: [RFC V2 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries From: Johannes Berg To: Arend van Spriel Cc: linux-wireless@vger.kernel.org Date: Fri, 28 Jun 2019 15:03:58 +0200 In-Reply-To: <1561461027-10793-6-git-send-email-arend.vanspriel@broadcom.com> References: <1561461027-10793-1-git-send-email-arend.vanspriel@broadcom.com> <1561461027-10793-6-git-send-email-arend.vanspriel@broadcom.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-06-25 at 13:10 +0200, Arend van Spriel wrote: > > +++ b/net/wireless/trace.h > @@ -2446,10 +2446,11 @@ > sizeof(int) * NUM_NL80211_BANDS); > ), > TP_printk(WIPHY_PR_FMT ", " NETDEV_PR_FMT ", " > - "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 60GHz=0x%x]", > + "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 6GHz=0x%x, 60GHz=0x%x]", > WIPHY_PR_ARG, NETDEV_PR_ARG, > __entry->mcast_rate[NL80211_BAND_2GHZ], > __entry->mcast_rate[NL80211_BAND_5GHZ], > + __entry->mcast_rate[NL80211_BAND_6GHZ], > __entry->mcast_rate[NL80211_BAND_60GHZ]) > ); This doesn't really - you just pointed out that legacy rates aren't permitted, and so this bitmap doesn't make sense for 6 GHz? johannes